From: Matthew Wilcox <willy@infradead.org>
To: Christopher Lameter <cl@linux.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
David Sterba <dsterba@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Ming Lei <ming.lei@redhat.com>,
Dave Chinner <david@fromorbit.com>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-btrfs@vger.kernel.org, Roman Gushchin <guro@fb.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two)
Date: Mon, 30 Sep 2019 06:32:03 -0700 [thread overview]
Message-ID: <20190930133203.GA26804@bombadil.infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.21.1909272251190.21341@www.lameter.com>
On Sat, Sep 28, 2019 at 01:12:49AM +0000, Christopher Lameter wrote:
> However, the layout may be different due to another allocator that prefers
> to arrange things differently (SLOB puts multiple objects of different
> types in the same page to save memory), if we need to add data to these
> objects (debugging info, new metadata about the object, maybe the memcg
> pointer, maybe other things that may come up), or other innovative
> approaches (such as putting data of different kmem caches that are
> commonly used together in the same page to improve locality).
If we ever do start putting objects of different sizes that are commonly
allocated together in the same page (eg inodes & dentries), then those
aren't going to be random kmalloc() allocation; they're going to be
special kmem caches that can specify "I don't care about alignment".
Also, we haven't done that. We've had a slab allocator for twenty years,
and nobody's tried to do that. Maybe the co-allocation would be a net
loss (I suspect). Or the gain is too small for the added complexity.
Whatever way, this is a strawman.
> The cost is an unnecessary petrification of the data layout of the memory
> allocators.
Yes, it is. And it's a cost I'm willing to pay in order to get the
guarantee of alignment.
next prev parent reply other threads:[~2019-09-30 13:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 11:16 [PATCH v2 0/2] guarantee natural alignment for kmalloc() Vlastimil Babka
2019-08-26 11:16 ` [PATCH v2 1/2] mm, sl[ou]b: improve memory accounting Vlastimil Babka
2019-08-26 11:16 ` [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two) Vlastimil Babka
2019-08-28 18:45 ` Christopher Lameter
2019-08-28 19:46 ` Matthew Wilcox
2019-08-28 22:24 ` Dave Chinner
2019-08-29 7:56 ` Vlastimil Babka
2019-08-30 0:29 ` Dave Chinner
2019-08-29 7:39 ` Michal Hocko
2019-08-30 17:41 ` Christopher Lameter
2019-09-01 0:52 ` Matthew Wilcox
2019-09-03 20:13 ` Christopher Lameter
2019-09-03 20:53 ` Matthew Wilcox
2019-09-04 5:19 ` Christoph Hellwig
2019-09-04 6:40 ` Ming Lei
2019-09-04 7:20 ` Vlastimil Babka
2019-09-04 19:31 ` Christopher Lameter
2019-09-23 16:36 ` Vlastimil Babka
2019-09-23 17:17 ` David Sterba
2019-09-23 17:51 ` Darrick J. Wong
2019-09-24 20:47 ` cl
2019-09-24 20:51 ` Matthew Wilcox
2019-09-24 20:55 ` cl
2019-09-26 13:02 ` David Sterba
2019-09-24 21:19 ` Vlastimil Babka
2019-09-24 21:53 ` Dave Chinner
2019-09-24 22:21 ` Darrick J. Wong
2019-09-24 20:52 ` cl
2019-09-24 23:54 ` Andrew Morton
2019-09-25 7:17 ` Vlastimil Babka
2019-09-26 0:16 ` Christopher Lameter
2019-09-26 0:14 ` Christopher Lameter
2019-09-26 7:41 ` Vlastimil Babka
2019-09-28 1:12 ` Christopher Lameter
2019-09-30 13:32 ` Matthew Wilcox [this message]
2019-09-23 17:54 ` Roman Gushchin
2019-09-30 8:06 ` Christoph Hellwig
2019-09-30 9:23 ` Michal Hocko
2019-09-30 9:32 ` Kirill A. Shutemov
2019-09-23 18:57 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930133203.GA26804@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dsterba@suse.cz \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).