From: Jeff Layton <jlayton@kernel.org>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, andres@anarazel.de,
willy@infradead.org, dhowells@redhat.com, hch@infradead.org,
jack@suse.cz, akpm@linux-foundation.org
Subject: [PATCH v3 2/3] buffer: record blockdev write errors in super_block that it backs
Date: Fri, 7 Feb 2020 12:04:22 -0500 [thread overview]
Message-ID: <20200207170423.377931-3-jlayton@kernel.org> (raw)
In-Reply-To: <20200207170423.377931-1-jlayton@kernel.org>
From: Jeff Layton <jlayton@redhat.com>
When syncing out a block device (a'la __sync_blockdev), any error
encountered will only be recorded in the bd_inode's mapping. When the
blockdev contains a filesystem however, we'd like to also record the
error in the super_block that's stored there.
Make mark_buffer_write_io_error also record the error in the
corresponding super_block when a writeback error occurs and the block
device contains a mounted superblock.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/buffer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/buffer.c b/fs/buffer.c
index b8d28370cfd7..451f1be6e1a4 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1166,6 +1166,8 @@ void mark_buffer_write_io_error(struct buffer_head *bh)
mapping_set_error(bh->b_page->mapping, -EIO);
if (bh->b_assoc_map)
mapping_set_error(bh->b_assoc_map, -EIO);
+ if (bh->b_bdev->bd_super)
+ errseq_set(&bh->b_bdev->bd_super->s_wb_err, -EIO);
}
EXPORT_SYMBOL(mark_buffer_write_io_error);
--
2.24.1
next prev parent reply other threads:[~2020-02-07 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 17:04 [PATCH v3 0/3] vfs: have syncfs() return error when there are writeback errors Jeff Layton
2020-02-07 17:04 ` [PATCH v3 1/3] vfs: track per-sb writeback errors and report them to syncfs Jeff Layton
2020-02-07 17:04 ` Jeff Layton [this message]
2020-02-07 17:04 ` [PATCH v3 3/3] vfs: add a new ioctl for fetching the superblock's errseq_t Jeff Layton
2020-02-07 20:52 ` [PATCH v3 0/3] vfs: have syncfs() return error when there are writeback errors Dave Chinner
2020-02-07 21:20 ` Andres Freund
2020-02-07 22:05 ` Jeff Layton
2020-02-07 22:21 ` Andres Freund
2020-02-10 21:46 ` Dave Chinner
2020-02-10 23:59 ` Andres Freund, David Howells
2020-02-11 0:04 ` Andres Freund
2020-02-11 0:48 ` Dave Chinner
2020-02-11 1:31 ` Andres Freund
2020-02-11 12:57 ` Jeff Layton
2020-02-12 12:21 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207170423.377931-3-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andres@anarazel.de \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).