From: Christoph Hellwig <hch@infradead.org>
To: Bob Peterson <rpeterso@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
Andreas Gruenbacher <agruenba@redhat.com>
Subject: Re: [PATCH] fs: clean up __block_commit_write
Date: Tue, 11 Feb 2020 23:33:54 -0800 [thread overview]
Message-ID: <20200212073354.GA7068@infradead.org> (raw)
In-Reply-To: <1350360444.7695146.1581449194730.JavaMail.zimbra@redhat.com>
> - __block_commit_write(inode, page, start, start+copied);
> + __block_commit_write(page, start, start+copied);
Please throew in the missing whitespaces around the + here.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-02-12 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527244171.7695063.1581449058353.JavaMail.zimbra@redhat.com>
2020-02-11 19:26 ` [PATCH] fs: clean up __block_commit_write Bob Peterson
2020-02-12 7:33 ` Christoph Hellwig [this message]
2020-02-13 13:57 ` [PATCH v2] " Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212073354.GA7068@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).