From: Matthew Wilcox <willy@infradead.org>
To: Goldwyn Rodrigues <rgoldwyn@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ritesh Harjani <riteshh@linux.ibm.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com
Subject: Re: [PATCH v2] iomap: return partial I/O count on error in iomap_dio_bio_actor
Date: Fri, 28 Feb 2020 11:59:54 -0800 [thread overview]
Message-ID: <20200228195954.GJ29971@bombadil.infradead.org> (raw)
In-Reply-To: <20200228194401.o736qvvr4zpklyiz@fiona>
On Fri, Feb 28, 2020 at 01:44:01PM -0600, Goldwyn Rodrigues wrote:
> +++ b/fs/iomap/direct-io.c
> @@ -264,7 +264,7 @@ iomap_dio_bio_actor(struct inode *inode, loff_t pos, loff_t length,
> size_t n;
> if (dio->error) {
> iov_iter_revert(dio->submit.iter, copied);
> - copied = ret = 0;
> + ret = 0;
> goto out;
There's another change here ... look at the out label
out:
/* Undo iter limitation to current extent */
iov_iter_reexpand(dio->submit.iter, orig_count - copied);
if (copied)
return copied;
return ret;
so you're also changing by how much the iter is reexpanded. I
don't know if it's the appropriate amount; I still don't quite get the
iov_iter complexities.
next prev parent reply other threads:[~2020-02-28 19:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 15:23 [PATCH v2] iomap: return partial I/O count on error in iomap_dio_bio_actor Goldwyn Rodrigues
2020-02-20 17:42 ` Matthew Wilcox
2020-02-21 2:06 ` Goldwyn Rodrigues
2020-02-21 4:51 ` Ritesh Harjani
2020-02-21 12:48 ` Goldwyn Rodrigues
2020-02-25 20:53 ` Christoph Hellwig
2020-02-26 2:12 ` Damien Le Moal
2020-02-26 2:55 ` Goldwyn Rodrigues
2020-02-28 19:44 ` Goldwyn Rodrigues
2020-02-28 19:59 ` Matthew Wilcox [this message]
2020-02-28 20:35 ` Goldwyn Rodrigues
2020-03-02 13:31 ` Christoph Hellwig
2020-02-21 13:14 ` David Sterba
2020-02-20 15:24 Goldwyn Rodrigues
2020-03-19 15:08 Goldwyn Rodrigues
2020-03-20 14:05 ` Christoph Hellwig
2020-03-20 14:23 ` Josef Bacik
2020-03-20 14:35 ` Christoph Hellwig
2020-03-20 15:35 ` Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228195954.GJ29971@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).