From: Luis Chamberlain <mcgrof@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org,
rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz,
ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org,
mhocko@suse.com, yukuai3@huawei.com, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/6] blktrace: break out of blktrace setup on concurrent calls
Date: Fri, 1 May 2020 15:40:50 +0000 [thread overview]
Message-ID: <20200501154050.GO11244@42.do-not-panic.com> (raw)
In-Reply-To: <20200501153423.GA12469@infradead.org>
On Fri, May 01, 2020 at 08:34:23AM -0700, Christoph Hellwig wrote:
> On Fri, May 01, 2020 at 03:06:26PM +0000, Luis Chamberlain wrote:
> > > You have access to a block device here, please use dev_warn() instead
> > > here for that, that makes it obvious as to what device a "concurrent
> > > blktrace" was attempted for.
> >
> > The block device may be empty, one example is for scsi-generic, but I'll
> > use buts->name.
>
> Is blktrace on /dev/sg something we intentionally support, or just by
> some accident of history? Given all the pains it causes I'd be tempted
> to just remove the support and see if anyone screams.
From what I can tell I think it was a historic and brutal mistake. I am
more than happy to remove it.
Re-adding support would just be a symlink.
Luis
next prev parent reply other threads:[~2020-05-01 15:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 7:46 [PATCH v3 0/6] block: fix blktrace debugfs use after free Luis Chamberlain
2020-04-29 7:46 ` [PATCH v3 1/6] block: revert back to synchronous request_queue removal Luis Chamberlain
2020-04-29 11:15 ` Christoph Hellwig
2020-05-02 0:22 ` Bart Van Assche
2020-05-03 10:32 ` Matthew Wilcox
2020-05-04 16:18 ` Luis Chamberlain
2020-05-04 16:16 ` Luis Chamberlain
2020-04-29 7:46 ` [PATCH v3 2/6] block: move main block debugfs initialization to its own file Luis Chamberlain
2020-04-29 11:15 ` Christoph Hellwig
2020-04-29 7:46 ` [PATCH v3 3/6] blktrace: move blktrace debugfs creation to helper function Luis Chamberlain
2020-04-29 11:20 ` Christoph Hellwig
2020-05-02 0:25 ` Bart Van Assche
2020-04-29 7:46 ` [PATCH v3 4/6] blktrace: fix debugfs use after free Luis Chamberlain
2020-04-29 9:47 ` Greg KH
2020-04-29 11:26 ` Christoph Hellwig
2020-04-29 11:45 ` Luis Chamberlain
2020-04-29 11:50 ` Christoph Hellwig
2020-04-29 12:02 ` Luis Chamberlain
2020-04-29 12:04 ` Christoph Hellwig
2020-04-29 12:21 ` Luis Chamberlain
2020-04-29 12:57 ` Greg KH
2020-05-01 15:24 ` Luis Chamberlain
2020-04-29 7:46 ` [PATCH v3 5/6] blktrace: break out of blktrace setup on concurrent calls Luis Chamberlain
2020-04-29 9:49 ` Greg KH
2020-05-01 15:06 ` Luis Chamberlain
2020-05-01 15:34 ` Christoph Hellwig
2020-05-01 15:40 ` Luis Chamberlain [this message]
2020-05-01 15:50 ` Luis Chamberlain
2020-05-01 16:51 ` Greg KH
2020-04-29 7:46 ` [PATCH v3 6/6] loop: be paranoid on exit and prevent new additions / removals Luis Chamberlain
2020-04-29 9:50 ` Greg KH
2020-05-03 9:09 ` Luis Chamberlain
2020-04-29 14:05 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501154050.GO11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=ming.lei@redhat.com \
--cc=mingo@redhat.com \
--cc=nstange@suse.de \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).