From: Tejun Heo <tj@kernel.org>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: akpm@linux-foundation.org, stable@vger.kernel.org, dxu@dxuuu.xyz,
chris@chrisdown.name, adilger@dilger.ca,
gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
hughd@google.com, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] vfs/xattr: mm/shmem: kernfs: release simple xattr entry in a right way
Date: Mon, 6 Jul 2020 10:58:58 -0400 [thread overview]
Message-ID: <20200706145858.GA5603@mtj.thefacebook.com> (raw)
In-Reply-To: <20200704051608.15043-1-cgxu519@mykernel.net>
On Sat, Jul 04, 2020 at 01:16:08PM +0800, Chengguang Xu wrote:
> After commit fdc85222d58e ("kernfs: kvmalloc xattr value
> instead of kmalloc"), simple xattr entry is allocated with
> kvmalloc() instead of kmalloc(), so we should release it
> with kvfree() instead of kfree().
>
> Cc: stable@vger.kernel.org # v5.7
> Cc: Daniel Xu <dxu@dxuuu.xyz>
> Cc: Chris Down <chris@chrisdown.name>
> Cc: Andreas Dilger <adilger@dilger.ca>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Hugh Dickins <hughd@google.com>
> Fixes: fdc85222d58e ("kernfs: kvmalloc xattr value instead of kmalloc")
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
prev parent reply other threads:[~2020-07-06 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-04 5:16 [PATCH v2] vfs/xattr: mm/shmem: kernfs: release simple xattr entry in a right way Chengguang Xu
2020-07-04 6:03 ` Hugh Dickins
2020-07-06 14:58 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706145858.GA5603@mtj.thefacebook.com \
--to=tj@kernel.org \
--cc=adilger@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=cgxu519@mykernel.net \
--cc=chris@chrisdown.name \
--cc=dxu@dxuuu.xyz \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).