From: Kalesh Singh <kaleshsingh@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Sumit Semwal <sumit.semwal@linaro.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org,
Suren Baghdasaryan <surenb@google.com>,
Hridya Valsaraju <hridya@google.com>,
Ioannis Ilkos <ilkos@google.com>,
John Stultz <john.stultz@linaro.org>,
kernel-team@android.com
Subject: Re: [PATCH 1/2] fs: Add fd_install file operation
Date: Mon, 3 Aug 2020 18:26:56 +0000 [thread overview]
Message-ID: <20200803182656.GA3230172@google.com> (raw)
In-Reply-To: <20200803163429.GA15200@infradead.org>
On Mon, Aug 03, 2020 at 05:34:29PM +0100, Christoph Hellwig wrote:
> On Mon, Aug 03, 2020 at 02:47:18PM +0000, Kalesh Singh wrote:
> > Provides a per process hook for the acquisition of file descriptors,
> > despite the method used to obtain the descriptor.
> >
> > Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
>
> I strongly disagree with this. The file operation has no business
> hooking into installing the fd.
Hi Christoph. I am exploring the alternative suggested by Matthew in
Patch 2/2. Thanks :)
next prev parent reply other threads:[~2020-08-03 18:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 14:47 [PATCH 0/2] Per process tracking of dma buffers Kalesh Singh
2020-08-03 14:47 ` [PATCH 1/2] fs: Add fd_install file operation Kalesh Singh
2020-08-03 16:34 ` Christoph Hellwig
2020-08-03 18:26 ` Kalesh Singh [this message]
2020-08-03 22:18 ` Al Viro
2020-08-04 0:30 ` Joel Fernandes
2020-08-04 13:54 ` Kalesh Singh
2020-08-03 14:47 ` [PATCH 2/2] dmabuf/tracing: Add dma-buf trace events Kalesh Singh
2020-08-03 15:32 ` Steven Rostedt
2020-08-03 16:33 ` Kalesh Singh
2020-08-03 15:41 ` Matthew Wilcox
2020-08-03 16:00 ` Suren Baghdasaryan
2020-08-03 16:12 ` Matthew Wilcox
2020-08-03 16:22 ` Suren Baghdasaryan
2020-08-03 22:28 ` Al Viro
2020-08-04 1:09 ` Al Viro
2020-08-04 2:10 ` Suren Baghdasaryan
2020-08-04 15:44 ` Kalesh Singh
2020-08-04 18:27 ` Al Viro
2020-08-04 20:42 ` Kalesh Singh
2020-08-04 20:26 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803182656.GA3230172@google.com \
--to=kaleshsingh@google.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=ilkos@google.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sumit.semwal@linaro.org \
--cc=surenb@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).