From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7248C5DF9D for ; Thu, 22 Oct 2020 16:40:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45C842464E for ; Thu, 22 Oct 2020 16:40:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MtK1TZXc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2897592AbgJVQkw (ORCPT ); Thu, 22 Oct 2020 12:40:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2897502AbgJVQkw (ORCPT ); Thu, 22 Oct 2020 12:40:52 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5A0BC0613CE; Thu, 22 Oct 2020 09:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IreJsWAehwwc9BigrWTsj0+t0+yJCwyFYLOnBdIPcSg=; b=MtK1TZXciwmKvAXJnEsSoBMqrf 72WiHkjyyFo9h6lPVsS32dBYqPHdi5iojV1xKAx6YuDdk1affu1pbBrT2k20OPlS+2gByBZEcvd9j MlFH0jBbmth/M/2D+92OFAiZfPEHzOaHPspxeiSjK15e6TDFdxwEjlSFuOSJj6rfmS8IzOOXphXvG Ht7qrXEw/cFXbdw4rjjzM4xSPRXX4g6iUWHMpU3Njtfxtxy5DA+zObVJbcYkefXEH4g9KJq62LzKN 0WCqRhPDlo3ZK7DTgaDVgnHVzVD3U2hWPPP4hFxd8Z8Po1erHVxohPm9W28iiZl9eK3OjpBjKRk8a +67cBPOg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVddo-0002sM-QL; Thu, 22 Oct 2020 16:40:40 +0000 Date: Thu, 22 Oct 2020 17:40:40 +0100 From: Matthew Wilcox To: David Laight Cc: 'Christoph Hellwig' , David Hildenbrand , Greg KH , Al Viro , Nick Desaulniers , "kernel-team@android.com" , Andrew Morton , Jens Axboe , Arnd Bergmann , David Howells , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-aio@kvack.org" , "io-uring@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "keyrings@vger.kernel.org" , "linux-security-module@vger.kernel.org" Subject: Re: Buggy commit tracked to: "Re: [PATCH 2/9] iov_iter: move rw_copy_check_uvector() into lib/iov_iter.c" Message-ID: <20201022164040.GV20115@casper.infradead.org> References: <80a2e5fa-718a-8433-1ab0-dd5b3e3b5416@redhat.com> <5d2ecb24db1e415b8ff88261435386ec@AcuMS.aculab.com> <20201022090155.GA1483166@kroah.com> <5fd6003b-55a6-2c3c-9a28-8fd3a575ca78@redhat.com> <20201022132342.GB8781@lst.de> <8f1fff0c358b4b669d51cc80098dbba1@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f1fff0c358b4b669d51cc80098dbba1@AcuMS.aculab.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Oct 22, 2020 at 04:35:17PM +0000, David Laight wrote: > Wait... > readv(2) defines: > ssize_t readv(int fd, const struct iovec *iov, int iovcnt); It doesn't really matter what the manpage says. What does the AOSP libc header say? > But the syscall is defined as: > > SYSCALL_DEFINE3(readv, unsigned long, fd, const struct iovec __user *, vec, > unsigned long, vlen) > { > return do_readv(fd, vec, vlen, 0); > }