linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Luca Vizzarro <Luca.Vizzarro@arm.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>,
	Jeff Layton <jlayton@kernel.org>,
	Chuck Lever <chuck.lever@oracle.com>,
	Kevin Brodsky <Kevin.Brodsky@arm.com>,
	Vincenzo Frascino <Vincenzo.Frascino@arm.com>,
	Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	David Laight <David.Laight@ACULAB.com>,
	Mark Rutland <Mark.Rutland@arm.com>,
	linux-fsdevel@vger.kernel.org, linux-morello@op-lists.linaro.org
Subject: [PATCH v2 0/5] Alter fcntl to handle int arguments correctly
Date: Fri, 14 Apr 2023 16:24:54 +0100	[thread overview]
Message-ID: <20230414152459.816046-1-Luca.Vizzarro@arm.com> (raw)

According to the documentation of fcntl, some commands take an int as
argument. In practice not all of them enforce this behaviour, as they
instead accept a more permissive long and in most cases not even a
range check is performed.

An issue could possibly arise from a combination of the handling of the
varargs in user space and the ABI rules of the target, which may result
in the top bits of an int argument being non-zero.

This issue was originally raised and detailed in the following thread:
  https://lore.kernel.org/linux-api/Y1%2FDS6uoWP7OSkmd@arm.com/
And was discovered during the porting of Linux to Morello [1].

This series modifies the interested commands so that they explicitly
take an int argument. It also propagates this change down to helper and
related functions as necessary.

This series is also available on my fork at:
  https://git.morello-project.org/Sevenarth/linux/-/commits/fcntl-int-handling-v2

Best regards,
Luca Vizzarro

[1] https://git.morello-project.org/morello/kernel/linux

Luca Vizzarro (5):
  fcntl: Cast commands with int args explicitly
  fs: Pass argument to fcntl_setlease as int
  pipe: Pass argument of pipe_fcntl as int
  memfd: Pass argument of memfd_fcntl as int
  dnotify: Pass argument of fcntl_dirnotify as int

 fs/cifs/cifsfs.c            |  2 +-
 fs/fcntl.c                  | 29 +++++++++++++++--------------
 fs/libfs.c                  |  2 +-
 fs/locks.c                  | 20 ++++++++++----------
 fs/nfs/nfs4_fs.h            |  2 +-
 fs/nfs/nfs4file.c           |  2 +-
 fs/nfs/nfs4proc.c           |  4 ++--
 fs/notify/dnotify/dnotify.c |  4 ++--
 fs/pipe.c                   |  6 +++---
 include/linux/dnotify.h     |  4 ++--
 include/linux/filelock.h    | 12 ++++++------
 include/linux/fs.h          |  6 +++---
 include/linux/memfd.h       |  4 ++--
 include/linux/pipe_fs_i.h   |  4 ++--
 mm/memfd.c                  |  6 +-----
 15 files changed, 52 insertions(+), 55 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-04-14 15:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 15:24 Luca Vizzarro [this message]
2023-04-14 15:24 ` [PATCH v2 1/5] fcntl: Cast commands with int args explicitly Luca Vizzarro
2023-04-14 15:46   ` Al Viro
2023-04-17  9:38     ` Mark Rutland
2023-04-18 10:51     ` Luca Vizzarro
2023-04-14 15:24 ` [PATCH v2 2/5] fs: Pass argument to fcntl_setlease as int Luca Vizzarro
2023-04-14 15:24 ` [PATCH v2 3/5] pipe: Pass argument of pipe_fcntl " Luca Vizzarro
2023-04-14 15:24 ` [PATCH v2 4/5] memfd: Pass argument of memfd_fcntl " Luca Vizzarro
2023-04-14 15:24 ` [PATCH v2 5/5] dnotify: Pass argument of fcntl_dirnotify " Luca Vizzarro
2023-07-06  8:30 ` [PATCH v2 0/5] Alter fcntl to handle int arguments correctly Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230414152459.816046-1-Luca.Vizzarro@arm.com \
    --to=luca.vizzarro@arm.com \
    --cc=David.Laight@ACULAB.com \
    --cc=Kevin.Brodsky@arm.com \
    --cc=Mark.Rutland@arm.com \
    --cc=Szabolcs.Nagy@arm.com \
    --cc=Vincenzo.Frascino@arm.com \
    --cc=brauner@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-morello@op-lists.linaro.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).