From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8034DC7EE23 for ; Sun, 11 Jun 2023 12:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231451AbjFKMIX (ORCPT ); Sun, 11 Jun 2023 08:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231337AbjFKMIT (ORCPT ); Sun, 11 Jun 2023 08:08:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E1EEE6F for ; Sun, 11 Jun 2023 05:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686485253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Z58VfawEkG4AD4FrE9MS4o9GTQRETweAw7Z1P68bgdU=; b=XzfmKe7ckGfO/IrjmfNnoxqV3LYoxuKxC7rqvXjm6vj4Vpikbxh8ia8qviv7tmZ9ejHDkH wA/P9E8fz1LFGgzSHHATsWe9nnhBEqCAB5aS6p/vRbZJ3IEwroLkqXEM9pKYeZCMF1GvrD r9cpDcsXTr6eDFrvWSqB1HEZhVHw4LY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-91ciCD_ZPaC8SMjQomdMcg-1; Sun, 11 Jun 2023 08:07:30 -0400 X-MC-Unique: 91ciCD_ZPaC8SMjQomdMcg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-75eba2e48cfso249209685a.0 for ; Sun, 11 Jun 2023 05:07:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686485250; x=1689077250; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z58VfawEkG4AD4FrE9MS4o9GTQRETweAw7Z1P68bgdU=; b=ltB1Nsdkp7TWIZMwUW7ngX6lTOoDubZe7/jcBJpwbVmuiTqP0QUslLI9iVr4wWNgAo tUM74t+XS4g5AShpXr5ZO0RRCgKbZTmp55XEr1d8Pbkea4QH7cN4ZKvmA73VL78Jg/HU hR7/IEIIAt1oSuGeZiYqe63t5a2C+NO6l81A3oHkGo5nx63Bh/jdVS9b1MgVAH0Df5SN dN5LjMn7B693y8rfo+x14SAFB0nbNsmCr7II1Q4U5AJO+NSOv5l7QYCsUQaKdZnNiDT9 SpeGVJajZ2woqHvWZ0NoMCIPOwKCcq7bi+F8p+l0K6MYv9nP6INVGKNCgyfji1PoKLZH 51Ew== X-Gm-Message-State: AC+VfDyWIYF4wx6K2CDooJ1vhSxTVYuK4mtZpnUMyzHRJTmnX8mSVhwC RyMJDoeN5idhwnwapiF0pfKrU4WsRfOk7azd+SCK9uJ/kmAcVddA2Z6yIsTlXkYcjPoNCeDBtSc bEITRCDlf4j0OKBiyP3Tqo0G/Kg== X-Received: by 2002:a05:620a:8c16:b0:760:6d74:a95c with SMTP id qz22-20020a05620a8c1600b007606d74a95cmr2209846qkn.7.1686485250033; Sun, 11 Jun 2023 05:07:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4bTsDwNHB0IlcStpaPGm7hD7NA2xjS6QujfNDUCS2WY21LjWZpujWvGqCwrwojYV04SAzHkQ== X-Received: by 2002:a05:620a:8c16:b0:760:6d74:a95c with SMTP id qz22-20020a05620a8c1600b007606d74a95cmr2209829qkn.7.1686485249829; Sun, 11 Jun 2023 05:07:29 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id y1-20020a37e301000000b00759495bb52fsm2208898qki.39.2023.06.11.05.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jun 2023 05:07:29 -0700 (PDT) From: Tom Rix To: mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tom Rix Subject: [PATCH] sysctl: set variable sysctl_mount_point storage-class-specifier to static Date: Sun, 11 Jun 2023 08:07:25 -0400 Message-Id: <20230611120725.183182-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org smatch reports fs/proc/proc_sysctl.c:32:18: warning: symbol 'sysctl_mount_point' was not declared. Should it be static? This variable is only used in its defining file, so it should be static. Signed-off-by: Tom Rix --- fs/proc/proc_sysctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 2715e6114933..67872cbc0517 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -29,7 +29,7 @@ static const struct file_operations proc_sys_dir_file_operations; static const struct inode_operations proc_sys_dir_operations; /* Support for permanently empty directories */ -struct ctl_table sysctl_mount_point[] = { +static struct ctl_table sysctl_mount_point[] = { {.flags = SYSCTL_PERM_EMPTY_DIR } }; -- 2.27.0