linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avadhut Naik <Avadhut.Naik@amd.com>
To: <rafael@kernel.org>, <gregkh@linuxfoundation.org>,
	<lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
	<linux-fsdevel@vger.kernel.org>
Cc: <avadnaik@amd.com>, <yazen.ghannam@amd.com>,
	<alexey.kardashevskiy@amd.com>, <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH v3 0/3] Add support for Vendor Defined Error Types in Einj Module
Date: Mon, 12 Jun 2023 21:51:36 +0000	[thread overview]
Message-ID: <20230612215139.5132-1-Avadhut.Naik@amd.com> (raw)

This patchset adds support for Vendor Defined Error types in the einj
module by exporting a binary blob file in module's debugfs directory.
Userspace tools can write OEM Defined Structures into the blob file as
part of injecting Vendor defined errors.

The first patch refactors available_error_type_show() function to ensure
all errors supported by the platform are output through einj module's
available_error_type file in debugfs.

The second patch adds a write callback for binary blobs created through
debugfs_create_blob() API.

The third adds the required support i.e. establishing the memory mapping
and exporting it through debugfs blob file for Vendor-defined Error types.

Changes in v2:
 - Split the v1 patch, as was recommended, to have a separate patch for
changes in debugfs.
 - Refactored available_error_type_show() function into a separate patch.
 - Changed file permissions to octal format to remove checkpatch warnings.

Changes in v3:
 - Use BIT macro for generating error masks instead of hex values since
ACPI spec uses bit numbers.
 - Handle the corner case of acpi_os_map_iomem() returning NULL through
a local variable to a store the size of OEM defined data structure.

Avadhut Naik (3):
  ACPI: APEI: EINJ: Refactor available_error_type_show()
  fs: debugfs: Add write functionality to debugfs blobs
  ACPI: APEI: EINJ: Add support for vendor defined error types

 drivers/acpi/apei/einj.c | 67 +++++++++++++++++++++++++++-------------
 fs/debugfs/file.c        | 28 ++++++++++++++---
 2 files changed, 69 insertions(+), 26 deletions(-)

-- 
2.34.1


             reply	other threads:[~2023-06-12 21:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 21:51 Avadhut Naik [this message]
2023-06-12 21:51 ` [RFC PATCH v3 1/3] ACPI: APEI: EINJ: Refactor available_error_type_show() Avadhut Naik
2023-06-12 21:51 ` [RFC PATCH v3 2/3] fs: debugfs: Add write functionality to debugfs blobs Avadhut Naik
2023-06-13  7:59   ` Greg KH
2023-06-13 10:05     ` Alexey Kardashevskiy
2023-06-13 10:22       ` Greg KH
2023-06-13 22:35         ` Avadhut Naik
2023-06-12 21:51 ` [RFC PATCH v3 3/3] ACPI: APEI: EINJ: Add support for vendor defined error types Avadhut Naik
2023-06-13  8:01 ` [RFC PATCH v3 0/3] Add support for Vendor Defined Error Types in Einj Module Greg KH
2023-06-13 22:34   ` Avadhut Naik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612215139.5132-1-Avadhut.Naik@amd.com \
    --to=avadhut.naik@amd.com \
    --cc=alexey.kardashevskiy@amd.com \
    --cc=avadnaik@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=yazen.ghannam@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).