From: "Darrick J. Wong" <djwong@kernel.org>
To: zenghongling <zenghongling@kylinos.cn>
Cc: hch@infradead.org, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, zhongling0719@126.com
Subject: Re: [PATCH] fs: Optimize unixbench's file copy test
Date: Fri, 30 Jun 2023 08:19:19 -0700 [thread overview]
Message-ID: <20230630151919.GK11441@frogsfrogsfrogs> (raw)
In-Reply-To: <1688117303-8294-1-git-send-email-zenghongling@kylinos.cn>
On Fri, Jun 30, 2023 at 05:28:23PM +0800, zenghongling wrote:
> The iomap_set_range_uptodate function checks if the file is a private
> mapping,and if it is, it needs to do something about it.UnixBench's
> file copy tests are mostly share mapping, such a check would reduce
> file copy scores, so we added the unlikely macro for optimization.
> and the score of file copy can be improved after branch optimization.
> As follows:
>
> ./Run -c 8 -i 3 fstime fsbuffer fsdisk
>
> Before the optimization
> System Benchmarks Partial Index BASELINE RESULT INDEX
> File Copy 1024 bufsize 2000 maxblocks 3960.0 689276.0 1740.6
> File Copy 256 bufsize 500 maxblocks 1655.0 204133.0 1233.4
> File Copy 4096 bufsize 8000 maxblocks 5800.0 1526945.0 2632.7
> ========
> System Benchmarks Index Score (Partial Only) 1781.3
>
> After the optimization
> System Benchmarks Partial Index BASELINE RESULT INDEX
> File Copy 1024 bufsize 2000 maxblocks 3960.0 741524.0 1872.5
> File Copy 256 bufsize 500 maxblocks 1655.0 208334.0 1258.8
> File Copy 4096 bufsize 8000 maxblocks 5800.0 1641660.0 2830.4
> ========
> System Benchmarks Index Score (Partial Only) 1882.6
Kernel version? And how does this intersect with the ongoing work to
use large folios throughout iomap?
--D
> Signed-off-by: zenghongling <zenghongling@kylinos.cn>
> ---
> fs/iomap/buffered-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 53cd7b2..35a50c2 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -148,7 +148,7 @@ iomap_set_range_uptodate(struct page *page, unsigned off, unsigned len)
> if (PageError(page))
> return;
>
> - if (page_has_private(page))
> + if (unlikely(page_has_private(page)))
> iomap_iop_set_range_uptodate(page, off, len);
> else
> SetPageUptodate(page);
> --
> 2.1.0
>
next prev parent reply other threads:[~2023-06-30 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 9:28 [PATCH] fs: Optimize unixbench's file copy test zenghongling
2023-06-30 15:19 ` Darrick J. Wong [this message]
2023-06-30 21:44 ` Matthew Wilcox
2023-07-05 4:49 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630151919.GK11441@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).