From: Jan Kara <jack@suse.cz>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Jan Kara <jack@suse.cz>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 03/32] block: Use blkdev_get_handle_by_dev() in blkdev_open()
Date: Wed, 5 Jul 2023 12:17:28 +0200 [thread overview]
Message-ID: <20230705101728.77szc5vpz4shrosl@quack3> (raw)
In-Reply-To: <20230705050510.GA28287@green245>
On Wed 05-07-23 10:35:10, Kanchan Joshi wrote:
> On Tue, Jul 04, 2023 at 02:21:30PM +0200, Jan Kara wrote:
> > Convert blkdev_open() to use blkdev_get_handle_by_dev().
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> > block/fops.c | 17 +++++++++--------
> > 1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/block/fops.c b/block/fops.c
> > index b6aa470c09ae..d7f3b6e67a2f 100644
> > --- a/block/fops.c
> > +++ b/block/fops.c
> > @@ -496,7 +496,7 @@ blk_mode_t file_to_blk_mode(struct file *file)
> >
> > static int blkdev_open(struct inode *inode, struct file *filp)
> > {
> > - struct block_device *bdev;
> > + struct bdev_handle *handle;
> > blk_mode_t mode;
> >
> > /*
> > @@ -509,24 +509,25 @@ static int blkdev_open(struct inode *inode, struct file *filp)
> > filp->f_mode |= FMODE_BUF_RASYNC;
> >
> > mode = file_to_blk_mode(filp);
> > - bdev = blkdev_get_by_dev(inode->i_rdev, mode,
> > - mode & BLK_OPEN_EXCL ? filp : NULL, NULL);
> > - if (IS_ERR(bdev))
> > - return PTR_ERR(bdev);
> > + handle = blkdev_get_handle_by_dev(inode->i_rdev, mode,
> > + mode & BLK_OPEN_EXCL ? filp : NULL, NULL);
> > + if (IS_ERR(handle))
> > + return PTR_ERR(handle);
> >
> > if (mode & BLK_OPEN_EXCL)
> > filp->private_data = filp;
>
> Is this needed?
> This is getting overwritten after a couple of lines below.
>
> > - if (bdev_nowait(bdev))
> > + if (bdev_nowait(handle->bdev))
> > filp->f_mode |= FMODE_NOWAIT;
> >
> > - filp->f_mapping = bdev->bd_inode->i_mapping;
> > + filp->f_mapping = handle->bdev->bd_inode->i_mapping;
> > filp->f_wb_err = filemap_sample_wb_err(filp->f_mapping);
> > + filp->private_data = handle;
>
> Here.
Good point, I'll fix that for the next version. Thanks for review!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-07-05 10:17 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 12:21 [PATCH RFC 0/32] block: Make blkdev_get_by_*() return handle Jan Kara
2023-07-04 12:21 ` [PATCH 01/32] block: Provide blkdev_get_handle_* functions Jan Kara
2023-07-04 12:43 ` Matthew Wilcox
2023-07-04 13:03 ` Jan Kara
2023-07-04 14:06 ` Bart Van Assche
2023-07-04 16:14 ` Matthew Wilcox
2023-07-05 15:19 ` Bart Van Assche
2023-07-05 16:12 ` Jan Kara
2023-07-04 16:28 ` Keith Busch
2023-07-05 10:21 ` Jan Kara
2023-07-06 15:38 ` Christoph Hellwig
2023-07-06 16:14 ` Jan Kara
2023-07-07 11:28 ` Christoph Hellwig
2023-07-07 12:24 ` Jan Kara
2023-07-12 16:06 ` Haris Iqbal
2023-07-31 10:50 ` Jan Kara
2023-07-31 11:13 ` Christoph Hellwig
2023-07-04 12:21 ` [PATCH 02/32] block: Use file->f_flags for determining exclusive opens in file_to_blk_mode() Jan Kara
2023-07-06 15:35 ` Christoph Hellwig
2023-07-06 16:35 ` Jan Kara
2023-07-07 11:29 ` Christoph Hellwig
2023-07-04 12:21 ` [PATCH 03/32] block: Use blkdev_get_handle_by_dev() in blkdev_open() Jan Kara
2023-07-05 5:05 ` Kanchan Joshi
2023-07-05 10:17 ` Jan Kara [this message]
2023-07-04 12:21 ` [PATCH 04/32] block: Use blkdev_get_handle_by_dev() in disk_scan_partitions() and blkdev_bszset() Jan Kara
2023-07-04 12:21 ` [PATCH 05/32] drdb: Convert to use blkdev_get_handle_by_path() Jan Kara
2023-07-04 12:21 ` [PATCH 06/32] pktcdvd: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 07/32] rnbd-srv: Convert to use blkdev_get_handle_by_path() Jan Kara
2023-07-12 15:54 ` Haris Iqbal
2023-07-04 12:21 ` [PATCH 08/32] xen/blkback: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 09/32] zram: Convert to use blkdev_get_handle_by_dev() Jan Kara
2023-07-05 0:52 ` Sergey Senozhatsky
2023-07-04 12:21 ` [PATCH 10/32] bcache: Convert to blkdev_get_handle_by_path() Jan Kara
2023-07-04 13:06 ` Coly Li
2023-07-04 12:21 ` [PATCH 11/32] dm: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 12/32] md: " Jan Kara
2023-07-04 12:21 ` [PATCH 13/32] mtd: block2mtd: Convert to blkdev_get_handle_by_dev/path() Jan Kara
2023-07-04 12:21 ` [PATCH 14/32] nvmet: Convert to blkdev_get_handle_by_path() Jan Kara
2023-07-04 12:21 ` [PATCH 15/32] s390/dasd: " Jan Kara
2023-07-04 12:21 ` [PATCH 16/32] scsi: target: " Jan Kara
2023-07-04 12:21 ` [PATCH 17/32] PM: hibernate: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 18/32] PM: hibernate: Drop unused snapshot_test argument Jan Kara
2023-07-04 12:21 ` [PATCH 19/32] mm/swap: Convert to use blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 20/32] fs: Convert to blkdev_get_handle_by_path() Jan Kara
2023-07-04 12:21 ` [PATCH 21/32] btrfs: " Jan Kara
2023-07-04 12:21 ` [PATCH 22/32] erofs: Convert to use blkdev_get_handle_by_path() Jan Kara
2023-07-06 15:16 ` Gao Xiang
2023-07-04 12:21 ` [PATCH 23/32] ext4: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 24/32] f2fs: Convert to blkdev_get_handle_by_dev/path() Jan Kara
2023-07-04 12:21 ` [PATCH 25/32] jfs: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-05 15:16 ` Dave Kleikamp
2023-07-04 12:21 ` [PATCH 26/32] nfs/blocklayout: Convert to use blkdev_get_handle_by_dev/path() Jan Kara
2023-07-04 12:21 ` [PATCH 27/32] nilfs2: Convert to use blkdev_get_handle_by_path() Jan Kara
2023-07-21 5:22 ` Ryusuke Konishi
2023-07-04 12:21 ` [PATCH 28/32] ocfs2: Convert to use blkdev_get_handle_by_dev() Jan Kara
2023-07-05 10:55 ` Joseph Qi
2023-07-04 12:21 ` [PATCH 29/32] reiserfs: Convert to blkdev_get_handle_by_dev/path() Jan Kara
2023-07-04 12:21 ` [PATCH 30/32] xfs: Convert to blkdev_get_handle_by_path() Jan Kara
2023-07-04 12:21 ` [PATCH 31/32] block: Remove blkdev_get_by_*() functions Jan Kara
2023-07-04 12:21 ` [PATCH 32/32] block: Rename blkdev_get_handle_by_*() and blkdev_handle_put() Jan Kara
2023-07-06 14:54 ` [PATCH RFC 0/32] block: Make blkdev_get_by_*() return handle Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705101728.77szc5vpz4shrosl@quack3 \
--to=jack@suse.cz \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).