From: Jan Kara <jack@suse.cz>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, Kees Cook <keescook@google.com>,
Ted Tso <tytso@mit.edu>, syzkaller <syzkaller@googlegroups.com>,
Alexander Popov <alex.popov@linux.com>,
Eric Biggers <ebiggers@google.com>,
linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH 6/6] fs: Make bind mounts work with bdev_allow_write_mounted=n
Date: Fri, 7 Jul 2023 12:48:36 +0200 [thread overview]
Message-ID: <20230707104836.bgamj6hjgcx745ul@quack3> (raw)
In-Reply-To: <20230707-mitangeklagt-erdumlaufbahn-688d4f493451@brauner>
On Fri 07-07-23 09:39:05, Christian Brauner wrote:
> On Thu, Jul 06, 2023 at 06:12:55PM +0200, Jan Kara wrote:
> > On Thu 06-07-23 08:55:18, Christoph Hellwig wrote:
> > > On Tue, Jul 04, 2023 at 02:56:54PM +0200, Jan Kara wrote:
> > > > When we don't allow opening of mounted block devices for writing, bind
> > > > mounting is broken because the bind mount tries to open the block device
> > > > before finding the superblock for it already exists. Reorganize the
> > > > mounting code to first look whether the superblock for a particular
> > > > device is already mounted and open the block device only if it is not.
> > >
> > > Warning: this might be a rathole.
> > >
> > > I really hate how mount_bdev / get_tree_bdev try to deal with multiple
> > > mounts.
> > >
> > > The idea to just open the device and work from there just feels very
> > > bogus.
> > >
> > > There is really no good reason to have the bdev to find a superblock,
> > > the dev_t does just fine (and in fact I have a patch to remove
> > > the bdev based get_super and just use the dev_t based one all the
> > > time). So I'd really like to actually turn this around and only
> > > open when we need to allocate a new super block. That probably
> > > means tearning sget_fc apart a bit, so it will turn into a fair
> > > amount of work, but I think it's the right thing to do.
> >
> > Well, this is exactly what this patch does - we use dev_t to lookup the
> > superblock in sget_fc() and we open the block device only if we cannot find
> > matching superblock and need to create a new one...
>
> Can you do this rework independent of the bdev_handle work that you're
> doing so this series doesn't depend on the other work and we can get
> the VFS bits merged for this?
Yeah, it should be doable. I'll have a look into it.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-07-07 10:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 12:56 [PATCH RFC 0/6 v2] block: Add config option to not allow writing to mounted devices Jan Kara
2023-07-04 12:56 ` [PATCH 1/6] " Jan Kara
2023-07-04 15:56 ` Colin Walters
2023-07-04 16:52 ` Eric Biggers
2023-08-14 16:41 ` Jan Kara
2023-08-14 16:43 ` Jan Kara
2023-07-04 18:44 ` Eric Biggers
2023-07-04 20:55 ` Theodore Ts'o
2023-07-05 10:30 ` Jan Kara
2023-07-05 15:12 ` Darrick J. Wong
2023-08-22 5:35 ` Eric Biggers
2023-08-22 10:11 ` Jan Kara
2023-10-19 9:16 ` Aleksandr Nogikh
2023-10-24 11:10 ` Jan Kara
2023-10-27 12:06 ` Aleksandr Nogikh
2023-11-08 10:10 ` Jan Kara
2023-11-08 18:24 ` Aleksandr Nogikh
2023-07-04 12:56 ` [PATCH 2/6] fs: Block writes to mounted block devices Jan Kara
2023-07-04 12:56 ` [PATCH 3/6] xfs: Block writes to log device Jan Kara
2023-07-04 15:53 ` Darrick J. Wong
2023-07-05 10:31 ` Jan Kara
2023-07-04 12:56 ` [PATCH 4/6] ext4: Block writes to journal device Jan Kara
2023-07-04 12:56 ` [PATCH 5/6] btrfs: Block writes to seed devices Jan Kara
2023-07-12 14:33 ` David Sterba
2023-07-04 12:56 ` [PATCH 6/6] fs: Make bind mounts work with bdev_allow_write_mounted=n Jan Kara
2023-07-04 13:59 ` Christian Brauner
2023-07-05 13:00 ` Jan Kara
2023-07-05 13:46 ` Christian Brauner
2023-07-05 16:14 ` Jan Kara
2023-07-06 15:55 ` Christoph Hellwig
2023-07-06 16:12 ` Jan Kara
2023-07-07 7:39 ` Christian Brauner
2023-07-07 10:48 ` Jan Kara [this message]
2023-07-07 11:31 ` Christoph Hellwig
2023-07-07 12:28 ` Jan Kara
2023-07-07 11:30 ` Christoph Hellwig
2023-07-04 13:40 ` [PATCH RFC 0/6 v2] block: Add config option to not allow writing to mounted devices Christian Brauner
2023-07-05 12:27 ` Mike Fleetwood
2023-08-14 16:39 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707104836.bgamj6hjgcx745ul@quack3 \
--to=jack@suse.cz \
--cc=alex.popov@linux.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dvyukov@google.com \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=keescook@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).