From: Jan Kara <jack@suse.cz>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Sterba <dsterba@suse.com>,
linux-fsdevel@vger.kernel.org,
Pankaj Raghav <p.raghav@samsung.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev, Theodore Tso <tytso@mit.edu>,
Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 6/7] jbd2: Use a folio in jbd2_journal_write_metadata_buffer()
Date: Mon, 31 Jul 2023 16:43:16 +0200 [thread overview]
Message-ID: <20230731144316.dft4li5saphuy6jx@quack3> (raw)
In-Reply-To: <20230713035512.4139457-7-willy@infradead.org>
On Thu 13-07-23 04:55:11, Matthew Wilcox (Oracle) wrote:
> The primary goal here is removing the use of set_bh_page().
> Take the opportunity to switch from kmap_atomic() to kmap_local().
> This simplifies the function as the offset is already added to
> the pointer.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/journal.c | 35 ++++++++++++++++-------------------
> 1 file changed, 16 insertions(+), 19 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index fbce16fedaa4..1b5a45ab62b0 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -341,7 +341,7 @@ int jbd2_journal_write_metadata_buffer(transaction_t *transaction,
> int do_escape = 0;
> char *mapped_data;
> struct buffer_head *new_bh;
> - struct page *new_page;
> + struct folio *new_folio;
> unsigned int new_offset;
> struct buffer_head *bh_in = jh2bh(jh_in);
> journal_t *journal = transaction->t_journal;
> @@ -370,14 +370,14 @@ int jbd2_journal_write_metadata_buffer(transaction_t *transaction,
> */
> if (jh_in->b_frozen_data) {
> done_copy_out = 1;
> - new_page = virt_to_page(jh_in->b_frozen_data);
> - new_offset = offset_in_page(jh_in->b_frozen_data);
> + new_folio = virt_to_folio(jh_in->b_frozen_data);
> + new_offset = offset_in_folio(new_folio, jh_in->b_frozen_data);
> } else {
> - new_page = jh2bh(jh_in)->b_page;
> - new_offset = offset_in_page(jh2bh(jh_in)->b_data);
> + new_folio = jh2bh(jh_in)->b_folio;
> + new_offset = offset_in_folio(new_folio, jh2bh(jh_in)->b_data);
> }
>
> - mapped_data = kmap_atomic(new_page);
> + mapped_data = kmap_local_folio(new_folio, new_offset);
> /*
> * Fire data frozen trigger if data already wasn't frozen. Do this
> * before checking for escaping, as the trigger may modify the magic
> @@ -385,18 +385,17 @@ int jbd2_journal_write_metadata_buffer(transaction_t *transaction,
> * data in the buffer.
> */
> if (!done_copy_out)
> - jbd2_buffer_frozen_trigger(jh_in, mapped_data + new_offset,
> + jbd2_buffer_frozen_trigger(jh_in, mapped_data,
> jh_in->b_triggers);
>
> /*
> * Check for escaping
> */
> - if (*((__be32 *)(mapped_data + new_offset)) ==
> - cpu_to_be32(JBD2_MAGIC_NUMBER)) {
> + if (*((__be32 *)mapped_data) == cpu_to_be32(JBD2_MAGIC_NUMBER)) {
> need_copy_out = 1;
> do_escape = 1;
> }
> - kunmap_atomic(mapped_data);
> + kunmap_local(mapped_data);
>
> /*
> * Do we need to do a data copy?
> @@ -417,12 +416,10 @@ int jbd2_journal_write_metadata_buffer(transaction_t *transaction,
> }
>
> jh_in->b_frozen_data = tmp;
> - mapped_data = kmap_atomic(new_page);
> - memcpy(tmp, mapped_data + new_offset, bh_in->b_size);
> - kunmap_atomic(mapped_data);
> + memcpy_from_folio(tmp, new_folio, new_offset, bh_in->b_size);
>
> - new_page = virt_to_page(tmp);
> - new_offset = offset_in_page(tmp);
> + new_folio = virt_to_folio(tmp);
> + new_offset = offset_in_folio(new_folio, tmp);
> done_copy_out = 1;
>
> /*
> @@ -438,12 +435,12 @@ int jbd2_journal_write_metadata_buffer(transaction_t *transaction,
> * copying, we can finally do so.
> */
> if (do_escape) {
> - mapped_data = kmap_atomic(new_page);
> - *((unsigned int *)(mapped_data + new_offset)) = 0;
> - kunmap_atomic(mapped_data);
> + mapped_data = kmap_local_folio(new_folio, new_offset);
> + *((unsigned int *)mapped_data) = 0;
> + kunmap_local(mapped_data);
> }
>
> - set_bh_page(new_bh, new_page, new_offset);
> + folio_set_bh(new_bh, new_folio, new_offset);
> new_bh->b_size = bh_in->b_size;
> new_bh->b_bdev = journal->j_dev;
> new_bh->b_blocknr = blocknr;
> --
> 2.39.2
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-07-31 14:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 3:55 [PATCH 0/7] More filesystem folio conversions for 6.6 Matthew Wilcox (Oracle)
2023-07-13 3:55 ` [PATCH 1/7] highmem: Add memcpy_to_folio() and memcpy_from_folio() Matthew Wilcox (Oracle)
2023-07-22 0:06 ` Andreas Grünbacher
2023-07-13 3:55 ` [PATCH 2/7] affs: Convert affs_symlink_read_folio() to use the folio Matthew Wilcox (Oracle)
2023-07-21 16:50 ` David Sterba
2023-07-13 3:55 ` [PATCH 3/7] affs: Convert data read and write to use folios Matthew Wilcox (Oracle)
2023-07-13 10:36 ` Pankaj Raghav
2023-07-21 16:51 ` David Sterba
2023-07-13 3:55 ` [PATCH 4/7] migrate: Use folio_set_bh() instead of set_bh_page() Matthew Wilcox (Oracle)
2023-07-31 14:44 ` Jan Kara
2023-07-13 3:55 ` [PATCH 5/7] ntfs3: Convert ntfs_get_block_vbo() to use a folio Matthew Wilcox (Oracle)
2023-07-13 3:55 ` [PATCH 6/7] jbd2: Use a folio in jbd2_journal_write_metadata_buffer() Matthew Wilcox (Oracle)
2023-07-31 14:43 ` Jan Kara [this message]
2023-07-13 3:55 ` [PATCH 7/7] buffer: Remove set_bh_page() Matthew Wilcox (Oracle)
2023-07-31 14:46 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731144316.dft4li5saphuy6jx@quack3 \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=dsterba@suse.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=p.raghav@samsung.com \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).