From: Christian Brauner <brauner@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "Michał Cłapiński" <mclapinski@google.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Shuah Khan" <shuah@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jeff Xu" <jeffxu@google.com>, "Aleksa Sarai" <cyphar@cyphar.com>,
"Daniel Verkamp" <dverkamp@chromium.org>,
"Marc Dionne" <marc.dionne@auristor.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/2] fcntl: add fcntl(F_CHECK_ORIGINAL_MEMFD)
Date: Mon, 4 Sep 2023 09:29:16 +0200 [thread overview]
Message-ID: <20230904-meistens-umeinander-3366194553a1@brauner> (raw)
In-Reply-To: <202309011133.10D66D0785@keescook>
On Fri, Sep 01, 2023 at 11:34:32AM -0700, Kees Cook wrote:
> On Fri, Sep 01, 2023 at 04:50:53PM +0200, Michał Cłapiński wrote:
> > On Fri, Sep 1, 2023 at 2:56 PM Christian Brauner <brauner@kernel.org> wrote:
> > >
> > > On Thu, Aug 31, 2023 at 10:36:46PM +0200, Michal Clapinski wrote:
> > > > Add a way to check if an fd points to the memfd's original open fd
> > > > (the one created by memfd_create).
> > > > Useful because only the original open fd can be both writable and
> > > > executable.
> > > >
> > > > Signed-off-by: Michal Clapinski <mclapinski@google.com>
> > > > ---
> > > > fs/fcntl.c | 3 +++
> > > > include/uapi/linux/fcntl.h | 9 +++++++++
> > > > 2 files changed, 12 insertions(+)
> > > >
> > > > diff --git a/fs/fcntl.c b/fs/fcntl.c
> > > > index e871009f6c88..301527e07a4d 100644
> > > > --- a/fs/fcntl.c
> > > > +++ b/fs/fcntl.c
> > > > @@ -419,6 +419,9 @@ static long do_fcntl(int fd, unsigned int cmd, unsigned long arg,
> > > > case F_SET_RW_HINT:
> > > > err = fcntl_rw_hint(filp, cmd, arg);
> > > > break;
> > > > + case F_CHECK_ORIGINAL_MEMFD:
> > > > + err = !(filp->f_mode & FMODE_WRITER);
> > > > + break;
> > >
> > > Honestly, make this an ioctl on memfds. This is so specific that it
> > > really doesn't belong into fcntl().
> >
> > I've never touched ioctls but if I'm correct, I can't just add it to
> > memfd. I would have to add it to the underlying fs, so hugetlbfs and
> > shmem (which I think can be defined as ramfs so also there). File
> > sealing fcntl is already memfd specific. Are you sure ioctl will be a
> > better idea?
fcntl() should be generic. Frankly, the sealing stuff should've gone
into an ioctl as well and only upgraded to a fcntl() once multiple fd
types support it.
>
> Does this check "mean" anything for other files? Because if it's
> generically useful (and got renamed) it maybe would be right for
> fcntl...
For regular files it just means that the file has gotten write access to
the underlying fs and we use this flag to release the necessary
refcounts/protections once the file is closed.
If this check has any meaning beyond that than it only has meaning for
memfd. I'm also not sure why this checks FMODE_WRITER and not
FMODE_WRITE as FMODE_WRITER is almost an entirely internal thing that
only very specific codepaths need to know about.
next prev parent reply other threads:[~2023-09-04 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 20:36 [PATCH 0/2] fcntl: add fcntl(F_CHECK_ORIGINAL_MEMFD) Michal Clapinski
2023-08-31 20:36 ` [PATCH 1/2] " Michal Clapinski
2023-09-01 12:56 ` Christian Brauner
2023-09-01 14:50 ` Michał Cłapiński
2023-09-01 18:34 ` Kees Cook
2023-09-04 7:29 ` Christian Brauner [this message]
2023-09-04 17:57 ` Michał Cłapiński
2023-09-05 8:37 ` Christian Brauner
2023-08-31 20:36 ` [PATCH 2/2] selftests: test fcntl(F_CHECK_ORIGINAL_MEMFD) Michal Clapinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230904-meistens-umeinander-3366194553a1@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chuck.lever@oracle.com \
--cc=cyphar@cyphar.com \
--cc=dverkamp@chromium.org \
--cc=jeffxu@google.com \
--cc=jlayton@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=mclapinski@google.com \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).