From: Greg KH <gregkh@linuxfoundation.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
mzxreary@0pointer.de, stefanha@redhat.com
Subject: Re: [Virtio-fs] [PATCH] virtiofs: Export filesystem tags through sysfs
Date: Sat, 11 Nov 2023 06:52:36 -0500 [thread overview]
Message-ID: <2023111104-iron-colossal-960f@gregkh> (raw)
In-Reply-To: <ZSRg2uiBNmY4mKHr@redhat.com>
On Mon, Oct 09, 2023 at 04:21:46PM -0400, Vivek Goyal wrote:
> On Mon, Oct 09, 2023 at 11:53:42AM +0200, Miklos Szeredi wrote:
> > On Thu, 5 Oct 2023 at 22:30, Vivek Goyal <vgoyal@redhat.com> wrote:
> > >
> > > virtiofs filesystem is mounted using a "tag" which is exported by the
> > > virtiofs device. virtiofs driver knows about all the available tags but
> > > these are not exported to user space.
> > >
> > > People have asked these tags to be exported to user space. Most recently
> > > Lennart Poettering has asked for it as he wants to scan the tags and mount
> > > virtiofs automatically in certain cases.
> > >
> > > https://gitlab.com/virtio-fs/virtiofsd/-/issues/128
> > >
> > > This patch exports tags through sysfs. One tag is associated with each
> > > virtiofs device. A new "tag" file appears under virtiofs device dir.
> > > Actual filesystem tag can be obtained by reading this "tag" file.
> > >
> > > For example, if a virtiofs device exports tag "myfs", a new file "tag"
> > > will show up here.
> > >
> > > /sys/bus/virtio/devices/virtio<N>/tag
> > >
> > > # cat /sys/bus/virtio/devices/virtio<N>/tag
> > > myfs
> > >
> > > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> >
> > Hi Vivek,
> >
> > This needs something under Documentation/.
>
> Hi Miklos,
>
> Hmm.., I can easily update the virtiofs documentation.
>
> Initially I was thinking to put something in Documentation/ABI/testing/
> as well. But I don't see any virtio related. In fact can't find any
> files related to "virtio" at all.
>
> So I will just update the Documentation/filesystems/virtiofs.rst for now.
No, please put it in Documentation/ABI/ that is where sysfs file
information goes, and where our tools actually look for it (and test for
it!)
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-11 11:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 20:30 [PATCH] virtiofs: Export filesystem tags through sysfs Vivek Goyal
2023-10-09 9:53 ` Miklos Szeredi
2023-10-09 20:21 ` [Virtio-fs] " Vivek Goyal
2023-11-11 11:52 ` Greg KH [this message]
2023-10-10 17:21 ` Stefan Hajnoczi
2023-10-11 18:08 ` German Maglione
2023-10-21 16:10 ` Alyssa Ross
2023-11-08 21:13 ` Vivek Goyal
2023-11-09 15:57 ` Alyssa Ross
2023-11-12 10:10 ` Stefan Hajnoczi
2023-11-11 11:53 ` Greg KH
2024-01-05 20:44 ` Vivek Goyal
2024-01-06 7:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023111104-iron-colossal-960f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mzxreary@0pointer.de \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).