From: Minjie Du <duminjie@vivo.com>
To: David Howells <dhowells@redhat.com>,
linux-cachefs@redhat.com (moderated list:FILESYSTEMS [NETFS
LIBRARY]),
linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS [NETFS
LIBRARY]), linux-kernel@vger.kernel.org (open list)
Cc: opensource.kernel@vivo.com, Minjie Du <duminjie@vivo.com>
Subject: [PATCH v1] netfs: use kfree_sensitive() instend of kfree() in fscache_free_cookie()
Date: Mon, 8 Jan 2024 19:27:11 +0800 [thread overview]
Message-ID: <20240108112713.20533-1-duminjie@vivo.com> (raw)
key might contain private information, so use kfree_sensitive to free it.
In fscache_free_cookie() use kfree_sensitive().
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
fs/netfs/fscache_cookie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/netfs/fscache_cookie.c b/fs/netfs/fscache_cookie.c
index bce2492186d0..5c917d87f281 100644
--- a/fs/netfs/fscache_cookie.c
+++ b/fs/netfs/fscache_cookie.c
@@ -74,7 +74,7 @@ static void fscache_free_cookie(struct fscache_cookie *cookie)
if (cookie->aux_len > sizeof(cookie->inline_aux))
kfree(cookie->aux);
if (cookie->key_len > sizeof(cookie->inline_key))
- kfree(cookie->key);
+ kfree_sensitive(cookie->key);
fscache_stat_d(&fscache_n_cookies);
kmem_cache_free(fscache_cookie_jar, cookie);
}
--
2.39.0
next reply other threads:[~2024-01-08 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 11:27 Minjie Du [this message]
2024-01-08 13:55 ` [PATCH v1] netfs: use kfree_sensitive() instend of kfree() in fscache_free_cookie() David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240108112713.20533-1-duminjie@vivo.com \
--to=duminjie@vivo.com \
--cc=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).