From: Christian Brauner <brauner@kernel.org>
To: Muchun Song <muchun.song@linux.dev>
Cc: Giuseppe Scrivano <gscrivan@redhat.com>,
linux-fsdevel@vger.kernel.org, rodrigo@sdfg.com.ar
Subject: Re: [PATCH] hugetlbfs: support idmapped mounts
Date: Fri, 1 Mar 2024 13:57:21 +0100 [thread overview]
Message-ID: <20240301-wedel-lenkung-db380eb1e90f@brauner> (raw)
In-Reply-To: <B8C52AAA-C8B5-4DF9-B9B2-A7DC1270E0AF@linux.dev>
On Fri, Mar 01, 2024 at 04:47:30PM +0800, Muchun Song wrote:
>
>
> > On Mar 1, 2024, at 16:09, Giuseppe Scrivano <gscrivan@redhat.com> wrote:
> >
> > Muchun Song <muchun.song@linux.dev> writes:
> >
> >>> On Feb 29, 2024, at 23:24, Giuseppe Scrivano <gscrivan@redhat.com> wrote:
> >>>
> >>> pass down the idmapped mount information to the different helper
> >>> functions.
> >>>
> >>> Differently, hugetlb_file_setup() will continue to not have any
> >>> mapping since it is only used from contexts where idmapped mounts are
> >>> not used.
> >>
> >> Sorry, could you explain more why you want this changes? What's the
> >> intention?
> >
> > we are adding user namespace support to Kubernetes to run each
> > pod (a group of containers) without overlapping IDs. We need idmapped
> > mounts for any mount shared among multiple pods.
> >
> > It was reported both for crun and containerd:
> >
> > - https://github.com/containers/crun/issues/1380
> > - https://github.com/containerd/containerd/issues/9585
>
> It is helpful and really should go into commit log to explain why it
> is necessary (those information will useful for others). The changes
> are straightforward, but I am not familiar with Idmappings (I am not
> sure if there are more things to be considered).
Fwiw, I've reviewed this before and it should be fine. I'll take another
close look at it but last time I didn't see anything obvious that would
be problematic so I'd be tempted to apply it unless there's specific
objections.
next prev parent reply other threads:[~2024-03-01 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 15:24 [PATCH] hugetlbfs: support idmapped mounts Giuseppe Scrivano
2024-03-01 6:45 ` Muchun Song
2024-03-01 8:09 ` Giuseppe Scrivano
2024-03-01 8:47 ` Muchun Song
2024-03-01 12:57 ` Christian Brauner [this message]
2024-03-04 12:55 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301-wedel-lenkung-db380eb1e90f@brauner \
--to=brauner@kernel.org \
--cc=gscrivan@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).