From: Luis Henriques <lhenriques@suse.de>
To: Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Henriques <lhenriques@suse.de>
Subject: [PATCH v2 0/3] fs_parser: handle parameters that can be empty and don't have a value
Date: Thu, 7 Mar 2024 16:02:22 +0000 [thread overview]
Message-ID: <20240307160225.23841-1-lhenriques@suse.de> (raw)
While investigating an ext4/053 fstest failure, I realised that there was
an issue when the flag 'fs_param_can_be_empty' is set in a parameter and it
doesn't have a value
After an initial attempt to fix the issue, Christian suggested a different
approach and the following patches are based in his suggestion.
Another change that I'm introducing in this v2 is the change of parameter
'test_dummy_encryption' to also use the new helper introduced by the first
patch in this series.
Finally, I'd like to ask someone to look closer at the overlayfs patch as
I don't think there were any fstests to validate the case where 'lowerdir'
is empty.
Luis Henriques (3):
fs_parser: add helper to define parameters with string and flag types
ext4: fix the parsing of empty string mount parameters
ovl: fix the parsing of empty string mount parameters
fs/ext4/super.c | 25 ++++++++++---------------
fs/overlayfs/params.c | 13 +++++--------
include/linux/fs_parser.h | 8 ++++++++
3 files changed, 23 insertions(+), 23 deletions(-)
next reply other threads:[~2024-03-07 18:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 16:02 Luis Henriques [this message]
2024-03-07 16:02 ` [PATCH v2 1/3] fs_parser: add helper to define parameters with string and flag types Luis Henriques
2024-03-07 16:02 ` [PATCH v2 2/3] ext4: fix the parsing of empty string mount parameters Luis Henriques
2024-03-25 4:39 ` kernel test robot
2024-03-07 16:02 ` [PATCH v2 3/3] ovl: " Luis Henriques
2024-03-11 9:25 ` Miklos Szeredi
2024-03-11 10:34 ` Luis Henriques
2024-03-11 10:53 ` Miklos Szeredi
2024-03-11 13:23 ` Luis Henriques
2024-03-11 13:25 ` Christian Brauner
2024-03-11 14:39 ` Miklos Szeredi
2024-03-11 18:01 ` Jan Kara
2024-03-12 8:50 ` Christian Brauner
2024-03-12 8:47 ` Christian Brauner
2024-03-12 10:31 ` Luis Henriques
2024-03-22 14:22 ` Christian Brauner
2024-03-22 15:17 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307160225.23841-1-lhenriques@suse.de \
--to=lhenriques@suse.de \
--cc=adilger.kernel@dilger.ca \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).