From: Kemeng Shi <shikemeng@huaweicloud.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfs: use helpers for calling f_op->{read,write}_iter() in read_write.c
Date: Mon, 28 Aug 2023 20:17:52 +0800 [thread overview]
Message-ID: <3283678e-1855-ed05-a9f2-44935bb806df@huaweicloud.com> (raw)
In-Reply-To: <ZOyMZO2i3rKS/4tU@infradead.org>
on 8/28/2023 8:00 PM, Christoph Hellwig wrote:
> On Mon, Aug 28, 2023 at 11:50:56PM +0800, Kemeng Shi wrote:
>> use helpers for calling f_op->{read,write}_iter() in read_write.c
>>
>
> Why? We really should just remove the completely pointless wrappers
> instead.
>
This patch is intended to uniform how we call {read,write}_iter()...
Would it be good to opencode all call_{read,write}_iter. But I'm not sure
if these wrappers are really needless...
next prev parent reply other threads:[~2023-08-28 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 15:50 [PATCH] vfs: use helpers for calling f_op->{read,write}_iter() in read_write.c Kemeng Shi
2023-08-28 12:00 ` Christoph Hellwig
2023-08-28 12:17 ` Kemeng Shi [this message]
2023-08-28 12:43 ` Matthew Wilcox
2023-08-28 12:19 ` Matthew Wilcox
2023-08-28 12:30 ` Christian Brauner
2023-08-28 14:09 ` Al Viro
2023-08-28 14:25 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3283678e-1855-ed05-a9f2-44935bb806df@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=brauner@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).