From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>,
zhangyi <yi.zhang@huawei.com>
Subject: Re: [PATCH] mm: use memalloc_nofs_save() in page_cache_ra_order()
Date: Sun, 28 Apr 2024 09:08:56 +0800 [thread overview]
Message-ID: <38017f5c-a74a-4d66-9092-efa79ffebfb9@huawei.com> (raw)
In-Reply-To: <Zix0zk2faI6HeG9D@casper.infradead.org>
On 2024/4/27 11:45, Matthew Wilcox wrote:
> On Fri, Apr 26, 2024 at 11:49:05AM -0700, Andrew Morton wrote:
>> On Fri, 26 Apr 2024 19:29:38 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>> io_schedule+0x24/0xa0
>>> __folio_lock+0x130/0x300
>>> migrate_pages_batch+0x378/0x918
>>> migrate_pages+0x350/0x700
>>> compact_zone+0x63c/0xb38
>>> compact_zone_order+0xc0/0x118
>>> try_to_compact_pages+0xb0/0x280
>>> __alloc_pages_direct_compact+0x98/0x248
>>> __alloc_pages+0x510/0x1110
>>> alloc_pages+0x9c/0x130
>>> folio_alloc+0x20/0x78
>>> filemap_alloc_folio+0x8c/0x1b0
>>> page_cache_ra_order+0x174/0x308
>>> ondemand_readahead+0x1c8/0x2b8
>>
>> I'm thinking
>>
>> Fixes: 793917d997df ("mm/readahead: Add large folio readahead")
>> Cc: stable
>
> I think it goes back earlier than that.
> https://lore.kernel.org/linux-mm/20200128060304.GA6615@bombadil.infradead.org/
> details how it can happen with the old readpages code. It's just easier
> to hit now.
>
The page_cache_ra_order() is introduced from 793917d997df, but previous
bugfix f2c817bed58d ("mm: use memalloc_nofs_save in readahead path")
don't Cc stable, so the previous patch should be posted to stable?
prev parent reply other threads:[~2024-04-28 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 11:29 [PATCH] mm: use memalloc_nofs_save() in page_cache_ra_order() Kefeng Wang
2024-04-26 18:49 ` Andrew Morton
2024-04-27 3:45 ` Matthew Wilcox
2024-04-28 1:08 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38017f5c-a74a-4d66-9092-efa79ffebfb9@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).