From: Jens Axboe <axboe@kernel.dk>
To: wenyang.linux@foxmail.com, Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Eric Biggers <ebiggers@google.com>,
Christoph Hellwig <hch@lst.de>, Dylan Yudaken <dylany@fb.com>,
David Woodhouse <dwmw@amazon.co.uk>, Fu Wei <wefu@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Michal Nazarewicz <m.nazarewicz@samsung.com>,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2] eventfd: use wait_event_interruptible_locked_irq() helper
Date: Wed, 5 Apr 2023 13:26:46 -0600 [thread overview]
Message-ID: <43fd324c-585c-d85b-230c-5b086e1aaa2c@kernel.dk> (raw)
In-Reply-To: <tencent_16F9553E8354D950D704214D6EA407315F0A@qq.com>
On 4/5/23 1:20 PM, wenyang.linux@foxmail.com wrote:
> From: Wen Yang <wenyang.linux@foxmail.com>
>
> wait_event_interruptible_locked_irq was introduced by commit 22c43c81a51e
> ("wait_event_interruptible_locked() interface"), but older code such as
> eventfd_{write,read} still uses the open code implementation.
> Inspired by commit 8120a8aadb20
> ("fs/timerfd.c: make use of wait_event_interruptible_locked_irq()"), this
> patch replaces the open code implementation with a single macro call.
>
> No functional change intended.
Looks pretty reasonable to me. How did you test it?
--
Jens Axboe
next prev parent reply other threads:[~2023-04-05 19:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 19:20 [RESEND PATCH v2] eventfd: use wait_event_interruptible_locked_irq() helper wenyang.linux
2023-04-05 19:26 ` Jens Axboe [this message]
2023-04-05 19:40 ` Wen Yang
2023-04-05 19:54 ` Jens Axboe
2023-04-06 9:08 ` Christian Brauner
2023-04-05 23:42 wenyang.linux
2023-04-06 15:03 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43fd324c-585c-d85b-230c-5b086e1aaa2c@kernel.dk \
--to=axboe@kernel.dk \
--cc=dwmw@amazon.co.uk \
--cc=dylany@fb.com \
--cc=ebiggers@google.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=pbonzini@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wefu@redhat.com \
--cc=wenyang.linux@foxmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).