From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] AFS fixes and other bits
Date: Sat, 16 Mar 2019 07:55:40 +0000 [thread overview]
Message-ID: <4841.1552722940@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHk-=wisFUf55wZ3o5pv8ZY5st9utSdWELAofsJ6AwAwYByPPg@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> The thing hasn't even seen a compiler, and when you *do* show the code
> to a compiler, said compiler correctly warns about
No, it doesn't - at least not gcc-8.3.1 on Fedora 29. What compiler are you
using?
> afs_do_silly_unlink() potentially returning an uninitialized variable.
Not only has it seen a compiler, it's also been tested numerous times, with
firefox, sqlite and some commands that tests file locking manually.
But please hold off for now. I've just tried the system flock program - and
that causes a lock leakage message for some reason that needs investigating.
David
next prev parent reply other threads:[~2019-03-16 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 23:41 [GIT PULL] AFS fixes and other bits David Howells
2019-03-16 1:49 ` Linus Torvalds
2019-03-16 7:55 ` David Howells [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-15 23:27 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4841.1552722940@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).