From: tchou <tchou@synology.com>
To: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
Cc: slava@dubeyko.com, linux-fsdevel@vger.kernel.org,
htl10@users.sourceforge.net, linux-fsdevel-owner@vger.kernel.org
Subject: Re: [PATCH] hfsplus: fix decomposition of Hangul characters
Date: Fri, 24 Aug 2018 09:20:43 +0800 [thread overview]
Message-ID: <606d90c202e7c555291c7dde9bf45297@synology.com> (raw)
In-Reply-To: <20180823182916.ajyci6expu535dcf@eaf>
Hi,
Ernesto A. Fernández 於 2018-08-24 02:29 寫到:
> Hi again:
>
> On Mon, Nov 27, 2017 at 04:36:54PM -0300, Ernesto A. Fernández wrote:
>> It would be good to have some feedback on the use of code under the
>> Unicode License, I don't know if that can be a problem.
>>
>> To Ting-Chang Hou: This patch is slightly different from the one you
>> tested with your mac. You are still tagged as Tested-by, but you may
>> want to check again that I have not broken anything.
>>
>> Thanks,
>> Ernest
>>
>> -- >8 --
>> Subject: [PATCH] hfsplus: fix decomposition of Hangul characters
>>
>> Files created under macOS become essentially unusable under linux if
>> their names contain any Hangul, and vice versa.
>>
>> This happens because the normalization of Hangul characters is a
>> special
>> case: it can be done algorithmically, without need of a table. The
>> hfsplus module deals with Hangul correctly when composing, but
>> completely forgets about it when performing a decomposition.
>>
>> Solve this by using the Hangul decomposition function provided in the
>> Unicode Standard. It's under the Unicode License, compatible with the
>> GPL.
>>
>> This patch will cause trouble for Hangul filenames already created by
>> the module in the past. This shouldn't be a special concern because
>> the
>> main purpose of the module was always sharing with macOS. If a user
>> actually needs to access such a file the nodecompose mount option
>> should
>> be enough.
>>
>> Reported-by: Ting-Chang Hou <tchou@synology.com>
>> Tested-by: Ting-Chang Hou <tchou@synology.com>
>> Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
>>
>
> It took a while but this patch has been merged now. Thanks again for
> your
> report.
And thanks for your patch, too.
>
> Ernest
next prev parent reply other threads:[~2018-08-24 4:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 8:20 [PATCH] hfsplus: fix the bug that cannot recognize files with hangul file name Ting-Chang Hou
2017-11-19 0:57 ` Ernesto A. Fernández
2017-11-23 3:57 ` tchou
2017-11-23 4:21 ` Viacheslav Dubeyko
2017-11-23 6:05 ` tchou
2017-11-23 6:23 ` Viacheslav Dubeyko
2017-11-23 6:34 ` tchou
2017-11-23 11:32 ` Ernesto A. Fernández
2017-11-23 18:36 ` Viacheslav Dubeyko
2017-11-23 22:20 ` Ernesto A. Fernández
2017-11-24 7:25 ` tchou
2017-11-24 11:45 ` Ernesto A. Fernández
2017-11-27 2:07 ` tchou
2017-11-27 19:36 ` [PATCH] hfsplus: fix decomposition of Hangul characters Ernesto A. Fernández
2017-11-27 22:40 ` Viacheslav Dubeyko
2017-11-28 15:02 ` Ernesto A. Fernández
2017-11-28 16:30 ` Viacheslav Dubeyko
2017-11-28 18:15 ` Ernesto A. Fernández
2018-08-23 18:29 ` Ernesto A. Fernández
2018-08-24 1:20 ` tchou [this message]
[not found] <1999104027.7153972.1511885718712.ref@mail.yahoo.com>
2017-11-28 16:15 ` Hin-Tak Leung
2017-11-28 17:50 ` Viacheslav Dubeyko
2017-11-28 18:51 ` Ernesto A. Fernández
[not found] <114108759.7167494.1511886580033.ref@mail.yahoo.com>
2017-11-28 16:29 ` Hin-Tak Leung
[not found] <1047295440.7535049.1511905720846.ref@mail.yahoo.com>
2017-11-28 21:48 ` Hin-Tak Leung
2017-11-28 23:10 ` Ernesto A. Fernández
[not found] <1691800505.7838608.1511945866988.ref@mail.yahoo.com>
2017-11-29 8:57 ` Hin-Tak Leung
2017-11-29 14:42 ` Ernesto A. Fernández
2017-11-29 16:28 ` Viacheslav Dubeyko
2017-11-30 4:03 ` Ernesto A. Fernández
[not found] <748914583.7912009.1511948801051.ref@mail.yahoo.com>
2017-11-29 9:46 ` Hin-Tak Leung
2018-07-17 22:09 Ernesto A. Fernández
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=606d90c202e7c555291c7dde9bf45297@synology.com \
--to=tchou@synology.com \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=htl10@users.sourceforge.net \
--cc=linux-fsdevel-owner@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).