From: Mukesh Ojha <mojha@codeaurora.org>
To: Yue Haibing <yuehaibing@huawei.com>,
adobriyan@gmail.com, akpm@linux-foundation.org, osandov@fb.com,
james.morse@arm.com, sfr@canb.auug.org.au
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH -next] proc/kcore: Make kcore_modules static
Date: Thu, 21 Mar 2019 01:25:30 +0530 [thread overview]
Message-ID: <6af0854e-b2c4-e5ce-ea2c-082d35f5e96e@codeaurora.org> (raw)
In-Reply-To: <20190320135417.13272-1-yuehaibing@huawei.com>
On 3/20/2019 7:24 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> fs/proc/kcore.c:591:19: warning:
> symbol 'kcore_modules' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> fs/proc/kcore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
> index bbcc185..378f453 100644
> --- a/fs/proc/kcore.c
> +++ b/fs/proc/kcore.c
> @@ -588,7 +588,7 @@ static void __init proc_kcore_text_init(void)
> /*
> * MODULES_VADDR has no intersection with VMALLOC_ADDR.
> */
> -struct kcore_list kcore_modules;
> +static struct kcore_list kcore_modules;
> static void __init add_modules_range(void)
> {
> if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
Acked-by: Mukesh Ojha <mojha@codeaurora.org>
prev parent reply other threads:[~2019-03-20 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 13:54 [PATCH -next] proc/kcore: Make kcore_modules static Yue Haibing
2019-03-20 19:55 ` Mukesh Ojha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6af0854e-b2c4-e5ce-ea2c-082d35f5e96e@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=james.morse@arm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=sfr@canb.auug.org.au \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).