From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57924 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750861AbeFAI1p (ORCPT ); Fri, 1 Jun 2018 04:27:45 -0400 From: David Howells In-Reply-To: <20180601063928.GS30522@ZenIV.linux.org.uk> References: <20180601063928.GS30522@ZenIV.linux.org.uk> <152720672288.9073.9868393448836301272.stgit@warthog.procyon.org.uk> <152720691829.9073.10564431140980997005.stgit@warthog.procyon.org.uk> <20180601062654.GA32397@infradead.org> To: Al Viro Cc: dhowells@redhat.com, Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 30/32] vfs: Allow cloning of a mount tree with open(O_PATH|O_CLONE_MOUNT) [ver #8] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <7066.1527841663.1@warthog.procyon.org.uk> Date: Fri, 01 Jun 2018 09:27:43 +0100 Message-ID: <7067.1527841663@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al Viro wrote: > > Instead of overloading this on open having a specific syscalls just > > seems like a much saner idea. > > It's not just mount API; these can be used independently of that. > Think of the uses where you pass those to ...at() and you'll see > a bunch of applications of that thing. I kind of agree with Christoph on this point. Yes, you can use the resultant fd for other things, but that doesn't mean it has to be obtained initially through open() or openat() rather than, say, a new pick_mount() syscall. Further, having more parameters available gives us the opportunity to change the settings on any mounts we create at the point of creation. David