From: Guoqing Jiang <jiangguoqing@kylinos.cn>
To: Anton Suvorov <warwish@yandex-team.ru>, willy@infradead.org
Cc: dmtrmonakhov@yandex-team.ru, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2 03/10] raid-md: reduce stack footprint dealing with block device names
Date: Wed, 23 Jun 2021 16:26:30 +0800 [thread overview]
Message-ID: <803a31fb-7b51-d160-5b3e-7736c0aa6d2d@kylinos.cn> (raw)
In-Reply-To: <20210622174424.136960-4-warwish@yandex-team.ru>
Hi,
Maybe replace "raid-md" with "md/raid" or just "md".
On 6/23/21 1:44 AM, Anton Suvorov wrote:
> Stack usage reduced (measured with allyesconfig):
>
> ./drivers/md/md-linear.c linear_make_request 248 112 -136
> ./drivers/md/md-multipath.c multipath_end_request 232 96 -136
> ./drivers/md/md-multipath.c multipath_error 208 72 -136
> ./drivers/md/md-multipath.c multipathd 248 112 -136
> ./drivers/md/md-multipath.c print_multipath_conf 208 64 -144
> ./drivers/md/md.c autorun_devices 312 184 -128
> ./drivers/md/md.c export_rdev 168 32 -136
> ./drivers/md/md.c md_add_new_disk 280 80 -200
> ./drivers/md/md.c md_import_device 200 56 -144
> ./drivers/md/md.c md_integrity_add_rdev 192 56 -136
> ./drivers/md/md.c md_ioctl 560 496 -64
> ./drivers/md/md.c md_reload_sb 224 88 -136
> ./drivers/md/md.c md_run 408 288 -120
> ./drivers/md/md.c md_seq_show 232 96 -136
> ./drivers/md/md.c md_update_sb 304 168 -136
> ./drivers/md/md.c read_disk_sb 184 48 -136
> ./drivers/md/md.c super_1_load 392 192 -200
> ./drivers/md/md.c super_90_load 304 112 -192
> ./drivers/md/md.c unbind_rdev_from_array 200 64 -136
> ./drivers/md/raid0.c create_strip_zones 400 200 -200
> ./drivers/md/raid0.c dump_zones 536 464 -72
> ./drivers/md/raid1.c fix_read_error 352 288 -64
> ./drivers/md/raid1.c print_conf 224 80 -144
> ./drivers/md/raid1.c raid1_end_read_request 216 80 -136
> ./drivers/md/raid1.c raid1_error 216 96 -120
> ./drivers/md/raid1.c sync_request_write 344 208 -136
> ./drivers/md/raid10.c fix_read_error 392 320 -72
> ./drivers/md/raid10.c print_conf 216 72 -144
> ./drivers/md/raid10.c raid10_end_read_request 216 80 -136
> ./drivers/md/raid10.c raid10_error 216 80 -136
> ./drivers/md/raid5-cache.c r5l_init_log 224 88 -136
> ./drivers/md/raid5-ppl.c ppl_do_flush 256 136 -120
> ./drivers/md/raid5-ppl.c ppl_flush_endio 192 56 -136
> ./drivers/md/raid5-ppl.c ppl_modify_log 192 56 -136
> ./drivers/md/raid5-ppl.c ppl_recover_entry 1296 1232 -64
> ./drivers/md/raid5-ppl.c ppl_submit_iounit_bio 192 56 -136
> ./drivers/md/raid5-ppl.c ppl_validate_rdev 184 48 -136
> ./drivers/md/raid5.c print_raid5_conf 208 64 -144
> ./drivers/md/raid5.c raid5_end_read_request 272 128 -144
> ./drivers/md/raid5.c raid5_error 216 80 -136
> ./drivers/md/raid5.c setup_conf 360 296 -64
>
> Signed-off-by: Anton Suvorov <warwish@yandex-team.ru>
> ---
> drivers/md/md-linear.c | 5 +-
> drivers/md/md-multipath.c | 24 +++----
> drivers/md/md.c | 135 ++++++++++++++------------------------
> drivers/md/raid0.c | 28 ++++----
> drivers/md/raid1.c | 25 +++----
> drivers/md/raid10.c | 65 ++++++++----------
> drivers/md/raid5-cache.c | 5 +-
> drivers/md/raid5-ppl.c | 40 +++++------
> drivers/md/raid5.c | 39 +++++------
> 9 files changed, 144 insertions(+), 222 deletions(-)
Also a nice cleanup! Acked-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
Thanks,
Guoqing
next prev parent reply other threads:[~2021-06-23 8:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 15:28 [PATCH 00/10] reduce stack footprint printing bdev names Anton Suvorov
2021-06-02 15:28 ` [PATCH 01/10] drbd: reduce stack footprint in drbd_report_io_error() Anton Suvorov
2021-06-02 15:28 ` [PATCH 02/10] dax: reduce stack footprint dealing with block device names Anton Suvorov
2021-06-02 17:18 ` Matthew Wilcox
2021-06-22 17:44 ` [PATCH v2 00/10] reduce stack footprint printing bdev names Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 01/10] drbd: reduce stack footprint in drbd_report_io_error() Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 02/10] dax: reduce stack footprint dealing with block device names Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 03/10] raid-md: " Anton Suvorov
2021-06-23 8:26 ` Guoqing Jiang [this message]
2021-06-22 17:44 ` [PATCH v2 04/10] dm: " Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 05/10] block: " Anton Suvorov
2021-06-23 7:45 ` Christoph Hellwig
2021-06-22 17:44 ` [PATCH v2 06/10] target: reduce stack footprint in iblock_show_configfs_dev_params() Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 07/10] vfs: reduce stack footprint in __blkdev_put() Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 08/10] ext4: reduce stack footprint in ext4_end_bio() Anton Suvorov
2021-06-22 17:44 ` [PATCH v2 09/10] security: reduce stack footprint in loadpin_read_file() Anton Suvorov
2021-06-22 17:45 ` [PATCH v2 10/10] block: remove unused symbol bio_devname() Anton Suvorov
2021-06-02 15:28 ` [PATCH 03/10] raid-md: reduce stack footprint dealing with block device names Anton Suvorov
2021-06-02 15:28 ` [PATCH 04/10] dm: " Anton Suvorov
2021-06-23 20:20 ` Mike Snitzer
2021-06-02 15:28 ` [PATCH 05/10] block: " Anton Suvorov
2021-06-02 15:28 ` [PATCH 06/10] target: reduce stack footprint in iblock_show_configfs_dev_params() Anton Suvorov
2021-06-02 15:29 ` [PATCH 07/10] vfs: reduce stack footprint in __blkdev_put() Anton Suvorov
2021-06-02 15:29 ` [PATCH 08/10] ext4: reduce stack footprint in ext4_end_bio() Anton Suvorov
2021-06-02 15:29 ` [PATCH 09/10] security: reduce stack footprint in loadpin_read_file() Anton Suvorov
2021-06-02 15:29 ` [PATCH 10/10] block: remove unused symbol bio_devname() Anton Suvorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=803a31fb-7b51-d160-5b3e-7736c0aa6d2d@kylinos.cn \
--to=jiangguoqing@kylinos.cn \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=warwish@yandex-team.ru \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).