From: Michael Ellerman <mpe@ellerman.id.au>
To: john.hubbard@gmail.com, Andrew Morton <akpm@linux-foundation.org>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dave Chinner" <david@fromorbit.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Jérôme Glisse" <jglisse@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org,
devel@driverdev.osuosl.org, devel@lists.orangefs.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-block@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org, linux-xfs@vger.kernel.org,
netdev@vger.kernel.org, rds-devel@oss.oracle.com,
sparclinux@vger.kernel.org, x86@kernel.org,
xen-devel@lists.xenproject.org,
"John Hubbard" <jhubbard@nvidia.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Christoph Hellwig" <hch@lst.de>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 38/41] powerpc: convert put_page() to put_user_page*()
Date: Thu, 08 Aug 2019 15:42:34 +1000 [thread overview]
Message-ID: <87k1botdpx.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20190807013340.9706-39-jhubbard@nvidia.com>
Hi John,
john.hubbard@gmail.com writes:
> diff --git a/arch/powerpc/mm/book3s64/iommu_api.c b/arch/powerpc/mm/book3s64/iommu_api.c
> index b056cae3388b..e126193ba295 100644
> --- a/arch/powerpc/mm/book3s64/iommu_api.c
> +++ b/arch/powerpc/mm/book3s64/iommu_api.c
> @@ -203,6 +202,7 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem)
> {
> long i;
> struct page *page = NULL;
> + bool dirty = false;
I don't think you need that initialisation do you?
> if (!mem->hpas)
> return;
> @@ -215,10 +215,9 @@ static void mm_iommu_unpin(struct mm_iommu_table_group_mem_t *mem)
> if (!page)
> continue;
>
> - if (mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY)
> - SetPageDirty(page);
> + dirty = mem->hpas[i] & MM_IOMMU_TABLE_GROUP_PAGE_DIRTY;
> - put_page(page);
> + put_user_pages_dirty_lock(&page, 1, dirty);
> mem->hpas[i] = 0;
> }
> }
cheers
next prev parent reply other threads:[~2019-08-08 5:42 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 1:32 [PATCH v3 00/39] put_user_pages(): miscellaneous call sites john.hubbard
2019-08-07 1:33 ` [PATCH v3 01/41] mm/gup: add make_dirty arg to put_user_pages_dirty_lock() john.hubbard
2019-08-07 1:33 ` [PATCH v3 02/41] drivers/gpu/drm/via: convert put_page() to put_user_page*() john.hubbard
2019-08-07 1:33 ` [PATCH v3 03/41] net/xdp: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 04/41] net/rds: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 05/41] net/ceph: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 06/41] x86/kvm: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 07/41] drm/etnaviv: convert release_pages() to put_user_pages() john.hubbard
2019-08-07 1:33 ` [PATCH v3 08/41] drm/i915: convert put_page() to put_user_page*() john.hubbard
2019-08-07 1:33 ` [PATCH v3 09/41] drm/radeon: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 10/41] media/ivtv: " john.hubbard
2019-08-07 8:51 ` Hans Verkuil
2019-08-07 1:33 ` [PATCH v3 11/41] media/v4l2-core/mm: " john.hubbard
2019-08-07 7:20 ` Sakari Ailus
2019-08-07 8:07 ` Hans Verkuil
2019-08-07 1:33 ` [PATCH v3 12/41] genwqe: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 13/41] scif: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 14/41] vmci: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 15/41] rapidio: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 16/41] oradax: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 17/41] staging/vc04_services: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 18/41] drivers/tee: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 19/41] vfio: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 20/41] fbdev/pvr2fb: " john.hubbard
2019-08-09 11:38 ` Bartlomiej Zolnierkiewicz
2019-08-07 1:33 ` [PATCH v3 21/41] fsl_hypervisor: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 22/41] xen: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 23/41] fs/exec.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 24/41] orangefs: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 25/41] uprobes: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 26/41] futex: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 27/41] mm/frame_vector.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 28/41] mm/gup_benchmark.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 29/41] mm/memory.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 30/41] mm/madvise.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 31/41] mm/process_vm_access.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 32/41] crypt: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 33/41] fs/nfs: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 34/41] goldfish_pipe: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 35/41] kernel/events/core.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 36/41] fs/binfmt_elf: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 37/41] security/tomoyo: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 38/41] powerpc: " john.hubbard
2019-08-08 5:42 ` Michael Ellerman [this message]
2019-08-09 1:26 ` John Hubbard
2019-08-09 12:20 ` Michael Ellerman
2019-08-07 1:33 ` [PATCH v3 39/41] mm/mlock.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 40/41] mm/mempolicy.c: " john.hubbard
2019-08-07 1:33 ` [PATCH v3 41/41] mm/ksm: " john.hubbard
2019-08-07 1:49 ` [PATCH v3 00/39] put_user_pages(): miscellaneous call sites John Hubbard
2019-08-30 1:29 ` Mike Marshall
2019-08-30 2:21 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1botdpx.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=benh@kernel.crashing.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@fromorbit.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@lists.orangefs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sparclinux@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).