From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [GIT PULL] afs: Fixes
Date: Mon, 14 May 2018 22:25:43 +0100 [thread overview]
Message-ID: <9747.1526333143@warthog.procyon.org.uk> (raw)
Hi Linus,
Here's a set of patches that fix a number of bugs in the in-kernel AFS
client, including:
(1) Fix directory locking to not use individual page locks for directory
reading/scanning but rather to use a semaphore on the afs_vnode struct
as the directory contents must be read in a single blob and data from
different reads must not be mixed as the entire contents may be
shuffled about between reads.
(2) Fix address list parsing to handle port specifiers correctly.
(3) Only give up callback records on a server if we actually talked to
that server (we might not be able to access a server).
(4) Fix some callback handling bugs, including refcounting, whole-volume
callbacks and when callbacks actually get broken in response to a
CB.CallBack op.
(5) Fix some server/address rotation bugs, including giving up if we can't
probe a server; giving up if a server says it doesn't have a volume,
but there are more servers to try.
(6) Fix the decoding of fetched statuses to be OpenAFS compatible.
(7) Fix the handling of server lookups in Cache Manager ops (such as
CB.InitCallBackState3) to use a UUID if possible and to handle no
server being found.
(8) Fix a bug in server lookup where not all addresses are compared.
(9) Fix the non-encryption of calls that prevents some servers from being
accessed (this also requires an AF_RXRPC patch that has already gone
in through the net tree).
There's also a patch that adds tracepoints to log Cache Manager ops that
don't find a matching server, either by UUID or by address.
Thanks,
David
---
The following changes since commit f0ab773f5c96c29a5227234c4b5a820f5591b74d:
Merge branch 'akpm' (patches from Andrew) (2018-05-11 18:04:12 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-fixes-20180514
for you to fetch changes up to 4776cab43fd3111618112737a257dc3ef368eddd:
afs: Fix the non-encryption of calls (2018-05-14 15:15:19 +0100)
----------------------------------------------------------------
AFS fixes
----------------------------------------------------------------
David Howells (13):
afs: Fix directory page locking
afs: Fix address list parsing
afs: Fix giving up callbacks on server destruction
afs: Fix refcounting in callback registration
afs: Fix server rotation's handling of fileserver probe failure
afs: Fix AFSFetchStatus decoder to provide OpenAFS compatibility
afs: Fix VNOVOL handling in address rotation
afs: Fix the handling of CB.InitCallBackState3 to find the server by UUID
afs: Add a tracepoint to record callbacks from unlisted servers
afs: Fix the handling of an unfound server in CM operations
afs: Fix whole-volume callback handling
afs: Fix CB.CallBack handling
afs: Fix the non-encryption of calls
Marc Dionne (1):
afs: Fix afs_find_server search loop
fs/afs/addr_list.c | 25 ++++++++------
fs/afs/callback.c | 84 +++++++++++++++++++++++++++++++++-------------
fs/afs/cmservice.c | 67 ++++++++++++------------------------
fs/afs/dir.c | 54 ++++++++++++++---------------
fs/afs/file.c | 2 +-
fs/afs/flock.c | 6 ++--
fs/afs/fsclient.c | 31 ++++++++++++-----
fs/afs/inode.c | 19 ++++++-----
fs/afs/internal.h | 25 ++++++++++++--
fs/afs/rotate.c | 20 +++++++----
fs/afs/rxrpc.c | 18 ++++++----
fs/afs/security.c | 7 ++--
fs/afs/server.c | 21 +++---------
fs/afs/server_list.c | 7 ++--
fs/afs/super.c | 4 +--
fs/afs/write.c | 2 +-
include/trace/events/afs.h | 42 +++++++++++++++++++++++
17 files changed, 266 insertions(+), 168 deletions(-)
next reply other threads:[~2018-05-14 21:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 21:25 David Howells [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-29 14:07 [GIT PULL] afs fixes David Howells
2020-10-29 17:31 ` pr-tracker-bot
2020-04-13 14:50 [GIT PULL] afs: Fixes David Howells
2020-04-13 15:13 ` David Howells
2020-04-14 19:05 ` pr-tracker-bot
2019-08-14 14:18 David Howells
2019-08-14 22:35 ` pr-tracker-bot
2019-08-14 14:15 David Howells
2019-06-26 13:39 [GIT PULL] AFS fixes David Howells
2019-06-28 0:45 ` pr-tracker-bot
2019-06-26 8:50 David Howells
2019-06-26 13:38 ` David Howells
2017-11-24 14:22 [GIT PULL] afs: Fixes David Howells
2017-11-25 18:05 ` Linus Torvalds
2017-11-25 22:35 ` David Howells
2017-11-25 22:48 ` Dave Chinner
2017-11-25 22:55 ` Linus Torvalds
2017-11-25 23:19 ` David Howells
2017-03-17 15:29 [GIT PULL] AFS fixes David Howells
2017-03-17 19:23 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9747.1526333143@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).