From: Adam Manzanares <Adam.Manzanares@wdc.com>
To: Christoph Hellwig <hch@lst.de>, Al Viro <viro@ZenIV.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>
Cc: kbuild test robot <lkp@intel.com>,
"kbuild-all@01.org" <kbuild-all@01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Jeff Moyer <jmoyer@redhat.com>
Subject: Re: [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap'
Date: Fri, 1 Jun 2018 15:38:45 +0000 [thread overview]
Message-ID: <9ad99d87-07c3-6611-3252-49d788f8028e@wdc.com> (raw)
In-Reply-To: <20180601051353.GA21589@lst.de>
My vote would be to move the ioprio code into fs/. At first glance I do
not see a dependence on the block layer in block/ioprio.c.
Any objections?
On 5/31/18 10:13 PM, Christoph Hellwig wrote:
>> +extern int ioprio_check_cap(int ioprio);
>
> Which then is implemented in block/ioprio.c, which depends on
> CONFIG_BLOCK. The code either needs a stub for !CONFIG_BLOCK
> or moved elsewhere.
>
next prev parent reply other threads:[~2018-06-01 15:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 0:36 [vfs:work.aio 10/12] fs/aio.c:1444: undefined reference to `ioprio_check_cap' kbuild test robot
2018-06-01 0:54 ` Al Viro
2018-06-01 1:02 ` Al Viro
2018-06-01 1:12 ` [kbuild-all] " Li, Philip
2018-06-01 5:13 ` Christoph Hellwig
2018-06-01 15:38 ` Adam Manzanares [this message]
2018-06-01 15:41 ` Jens Axboe
2018-06-01 15:57 ` Adam Manzanares
2018-06-01 15:59 ` Jens Axboe
2018-06-01 17:28 ` Matthew Wilcox
2018-06-01 20:31 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ad99d87-07c3-6611-3252-49d788f8028e@wdc.com \
--to=adam.manzanares@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jmoyer@redhat.com \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).