linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: harshad shirwadkar <harshadshirwadkar@gmail.com>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4_FS=m
Date: Tue, 13 Oct 2020 10:43:24 -0700	[thread overview]
Message-ID: <CAD+ocbzz_7KwzMo6UpSLef6i7aFWg9O+25DqtOGj=nvRNqbcsQ@mail.gmail.com> (raw)
In-Reply-To: <CA+icZUUp9gXGcDrX1rD2PNJfTTOe6JjfMTYiunjT9WTqCRVKRg@mail.gmail.com>

Thanks Sedat, I'll take care of this in V10.

On Fri, Oct 9, 2020 at 8:14 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>
> On Fri, Oct 9, 2020 at 6:04 PM harshad shirwadkar
> <harshadshirwadkar@gmail.com> wrote:
> >
> > Thanks Sedat for pointing that out and also sending out the fixes.
> > Ted, should I send out another version of fast commits out with
> > Sedat's fixes?
> >
>
> Hi Harshad,
>
> when you work on v10, can you look at these warnings, please?
>
> fs/jbd2/recovery.c:241:15: warning: unused variable 'seq' [-Wunused-variable]
> fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used
> uninitialized whenever 'if' condition is true
> [-Wsometimes-uninitialized]
> fs/ext4/fast_commit.c:1091:6: warning: variable 'start_time' is used
> uninitialized whenever '||' condition is true
> [-Wsometimes-uninitialized]
>
> Thanks,
> - Sedat -
>
> P.S.: Now, I see that ext4.git#dev has dropped the hs/fast-commit v9 merge.
>
> >
> >
> > On Fri, Oct 9, 2020 at 8:45 AM Theodore Y. Ts'o <tytso@mit.edu> wrote:
> > >
> > > On Fri, Oct 09, 2020 at 04:31:51PM +0200, Sedat Dilek wrote:
> > > > > This fixes it...
> > >
> > > Sedat,
> > >
> > > Thanks for the report and the proposed fixes!
> > >
> > >                                         - Ted

      reply	other threads:[~2020-10-13 17:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 13:49 ext4: dev: Broken with CONFIG_JBD2=and CONFIG_EXT4_FS=m Sedat Dilek
2020-10-09 14:10 ` Sedat Dilek
2020-10-09 14:31   ` Sedat Dilek
2020-10-09 15:45     ` Theodore Y. Ts'o
2020-10-09 16:03       ` harshad shirwadkar
2020-10-09 16:12         ` Sedat Dilek
2020-10-10  3:14         ` Sedat Dilek
2020-10-13 17:43           ` harshad shirwadkar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD+ocbzz_7KwzMo6UpSLef6i7aFWg9O+25DqtOGj=nvRNqbcsQ@mail.gmail.com' \
    --to=harshadshirwadkar@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sedat.dilek@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).