Re: [PATCH 2/2] kernel: use sysctl shared variables for range check

From: Kees Cook <keescook@chromium.org>
To: Matteo Croce <mcroce@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH 2/2] kernel: use sysctl shared variables for range check
Date: Wed, 10 Apr 2019 15:59:55 -0700	[thread overview]
Message-ID: <CAGXu5j+2CLGmx_Sd+r-GXxPcCg3PfyQDU8ohJfCzxFku5_WzvQ@mail.gmail.com> (raw)
In-Reply-To: <CAGnkfhyeUdN+H4g9Lx4X2ae9k3crLrZQjQYZVjNE4ZyM8ziY9g@mail.gmail.com>

On Wed, Apr 10, 2019 at 3:54 PM Matteo Croce <mcroce@redhat.com> wrote:
>
> On Thu, Apr 11, 2019 at 12:34 AM Kees Cook <keescook@chromium.org> wrote:
> >
> > On Wed, Apr 10, 2019 at 3:30 PM Matteo Croce <mcroce@redhat.com> wrote:
> > >
> > > FYI, this are the stats from my local repo, just to let you the size
> > > of a series with all the changes in it:
> > >
> > > $ git --no-pager log --stat --oneline linus/master
> > >  2 files changed, 4 insertions(+), 9 deletions(-)
> > >  2 files changed, 7 insertions(+), 14 deletions(-)
> > >  6 files changed, 15 insertions(+), 30 deletions(-)
> > >  1 file changed, 16 insertions(+), 19 deletions(-)
> > >  1 file changed, 3 insertions(+), 5 deletions(-)
> > >  3 files changed, 15 insertions(+), 20 deletions(-)
> > >  12 files changed, 93 insertions(+), 116 deletions(-)
> > >  3 files changed, 98 insertions(+), 104 deletions(-)
> > >  2 files changed, 9 insertions(+)
> >
> > Tiny! :) Seriously, though, I think this should be fine to take
> > directly to Linus after patch 1 lands, or see if akpm wants to carry
> > it directly.
> >
> > --
> > Kees Cook
>
> Nice. Still as an 8 patches series, or squashed into a bigger one?

I suspect a single patch would be fine, but let's wait to hear from akpm.

-- 
Kees Cook