From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8092C43381 for ; Tue, 26 Feb 2019 00:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A541E217F4 for ; Tue, 26 Feb 2019 00:07:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551139656; bh=XcfZxoyF1741C1XnA6YchOUdnu5dIJOPZnv9emuQMVc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=rEgdCYoi5NBoseRKoJxQ/mFgyomHvgOOXFVisOKcyVIXMSpih9v92HLGKbNc8IxWv +vQ3Y3SPAsJSZ6ey6vVe0XwASHiBUc9TA1wkxL9sSPTzMz46D/DLuBPyBs/VpI3Dw1 Loy0F9d0i0kSRBvb+wC6CYTxVtVSwPrN/2GFk9JU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729154AbfBZAHd (ORCPT ); Mon, 25 Feb 2019 19:07:33 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:33332 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728713AbfBZAHd (ORCPT ); Mon, 25 Feb 2019 19:07:33 -0500 Received: by mail-lf1-f67.google.com with SMTP id q12so8304857lfm.0 for ; Mon, 25 Feb 2019 16:07:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0/RCL+H9yC/RWFMtaWm284KCaP64OOSmBn5G9YZ2KtA=; b=bNZr7nXI+nIktrAxf5ZjL1b7XP4SSnerSSU1J8dZOjk6LLGkSlefNh6KNOMaAxUP9u m2XpNxKf3eJLN3njAYmwKY0KuQSXY+s+ijf1ib1CUS3T6gjAfGM6JVVd9dZ6/Le/ISG6 qF+2IPWv+qy16dnaD1+WDd7yY2DMNYpVUumbU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0/RCL+H9yC/RWFMtaWm284KCaP64OOSmBn5G9YZ2KtA=; b=F/yXHyV0xOk7gQfHAHoxogQLbdP9XmmHYq8Vnz2jFI4DqpMWr/jF+SxPonPD18lK6G wlD78AgkVJaDU9qL4qOG3XlghgRnXnkXDxd4ieFqS2rgZIuSRrTLdr1r/T2oTPZdJ7QO oKOfYX8i9Az+VsC/PMRKdozPeRcjF4P2w1OhiWDOEoNdP/xDEkrzyO/RoeotaNvLbAjw ah4C1F+HBtcJNov5B932orxVC7+W/IiOCE62g4nmzfFq2G4BoBV0HlY7yXOI7q3P1O7+ prvQeVTNmipYHD3FXGb8TfJqnHHyW8pvqLmom9iQAPxvAo8RWfD8bRoY2UQs9U/hY0zz Y61Q== X-Gm-Message-State: AHQUAuaaGpTmqP69X78bmHeqbJdAGXB5u4WUcPwUw/xqVMFWarST05xu 1PUiwqPb7KM4QMyxi3TPOowUw7KdOtw= X-Google-Smtp-Source: AHgI3IaqOXdPzkISqHcl9Nheldr+5x1a+YAHRzI93ogJ5eHODTQVifHT2fZJDQNm/5b9RGX1gJ4Biw== X-Received: by 2002:a19:e347:: with SMTP id c7mr11416156lfk.137.1551139650318; Mon, 25 Feb 2019 16:07:30 -0800 (PST) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id h26sm2582999ljf.5.2019.02.25.16.07.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 16:07:29 -0800 (PST) Received: by mail-lj1-f175.google.com with SMTP id a17so9111343ljd.4 for ; Mon, 25 Feb 2019 16:07:28 -0800 (PST) X-Received: by 2002:a2e:9786:: with SMTP id y6mr10251793lji.79.1551139648545; Mon, 25 Feb 2019 16:07:28 -0800 (PST) MIME-Version: 1.0 References: <20190221222123.GC6474@magnolia> <86649ee4-9794-77a3-502c-f4cd10019c36@lca.pw> In-Reply-To: <86649ee4-9794-77a3-502c-f4cd10019c36@lca.pw> From: Linus Torvalds Date: Mon, 25 Feb 2019 16:07:12 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] tmpfs: fix uninitialized return value in shmem_link To: Qian Cai Cc: Hugh Dickins , "Darrick J. Wong" , Andrew Morton , Matej Kupljen , Al Viro , Dan Carpenter , Linux List Kernel Mailing , linux-fsdevel , Linux-MM Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Feb 25, 2019 at 4:03 PM Qian Cai wrote: > > > > Of course, that's just gcc. I have no idea what llvm ends up doing. > > Clang 7.0: > > # clang -O2 -S -Wall /tmp/test.c > /tmp/test.c:46:6: warning: variable 'ret' is used uninitialized whenever 'if' > condition is false [-Wsometimes-uninitialized] Ok, good. Do we have any clang builds in any of the zero-day robot infrastructure or something? Should we? And maybe this was how Dan noticed the problem in the first place? Or is it just because of his eagle-eyes? Linus