From: Linus Torvalds <torvalds@linux-foundation.org>
To: Gabriel Krisman Bertazi <krisman@suse.de>
Cc: ebiggers@kernel.org, viro@zeniv.linux.org.uk, tytso@mit.edu,
linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org
Subject: Re: [PATCH v3 1/2] dcache: Expose dentry_string_cmp outside of dcache
Date: Sun, 21 Jan 2024 11:09:01 -0800 [thread overview]
Message-ID: <CAHk-=wh+4Msg7RKv6mvKz2LfNwK24zKFhnLUyxsrKzsXqni+Kg@mail.gmail.com> (raw)
In-Reply-To: <87mssywsqs.fsf@mailhost.krisman.be>
On Sun, 21 Jan 2024 at 08:34, Gabriel Krisman Bertazi <krisman@suse.de> wrote:
>
> Are you ok with the earlier v2 of this patchset as-is, and I'll send a
> new series proposing this change?
Yeah, possibly updating just the commit log to mention how
__d_lookup_rcu_op_compare() takes care of the data race.
I do think that just doing the exact check in
__d_lookup_rcu_op_compare() would then avoid things like the indirect
call for that (presumably common) case, but it's not a big deal.
Linus
next prev parent reply other threads:[~2024-01-21 19:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 20:25 [PATCH v3 0/2] Try exact-match comparison ahead of case-insensitive match Gabriel Krisman Bertazi
2024-01-19 20:25 ` [PATCH v3 1/2] dcache: Expose dentry_string_cmp outside of dcache Gabriel Krisman Bertazi
2024-01-19 20:48 ` Linus Torvalds
2024-01-21 16:34 ` Gabriel Krisman Bertazi
2024-01-21 19:09 ` Linus Torvalds [this message]
2024-01-24 18:13 ` [PATCH v4] libfs: Attempt exact-match comparison first during casefolded lookup Gabriel Krisman Bertazi
2024-01-24 18:42 ` Linus Torvalds
2024-01-24 22:44 ` Eric Biggers
2024-01-19 20:25 ` [PATCH v3 2/2] libfs: Attempt exact-match comparison first during casefold lookup Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh+4Msg7RKv6mvKz2LfNwK24zKFhnLUyxsrKzsXqni+Kg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=krisman@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).