From: Arnd Bergmann <arnd@arndb.de>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: "Namjae Jeon" <linkinjeon@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Linux FS-devel Mailing List" <linux-fsdevel@vger.kernel.org>,
gregkh <gregkh@linuxfoundation.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Valdis Kletnieks" <valdis.kletnieks@vt.edu>,
"Christoph Hellwig" <hch@lst.de>,
sj1557.seo@samsung.com
Subject: Re: [PATCH v10 09/14] exfat: add misc operations
Date: Fri, 17 Jan 2020 11:13:39 +0100 [thread overview]
Message-ID: <CAK8P3a28NRp+SGr44=DTYqL0+ZqtamHwn+WYNTxVRJOJ3HtLSg@mail.gmail.com> (raw)
In-Reply-To: <002801d5cce2$228d79f0$67a86dd0$@samsung.com>
On Fri, Jan 17, 2020 at 3:59 AM Namjae Jeon <namjae.jeon@samsung.com> wrote:
>
>
> > This is what I think the timezone mount option should be used
> > for: if we don't know what the timezone was for the on-disk timestamp, use
> > the one provided by the user. However, if none was specified, it should be
> > either sys_tz or UTC (i.e. no conversion). I would prefer the use of UTC
> > here given the problems with sys_tz, but sys_tz would be more consistent
> > with how fs/fat works.
> Hi Arnd,
>
> Could you please review this change ?
Looks all good to me now.
Arnd
> /* Convert a EXFAT time/date pair to a UNIX date (seconds since 1 1 70). */
> void exfat_get_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
> __le16 time, __le16 date, u8 tz)
> {
> u16 t = le16_to_cpu(time);
> u16 d = le16_to_cpu(date);
>
> ts->tv_sec = mktime64(1980 + (d >> 9), d >> 5 & 0x000F, d & 0x001F,
> t >> 11, (t >> 5) & 0x003F, (t & 0x001F) << 1);
> ts->tv_nsec = 0;
>
> if (tz & EXFAT_TZ_VALID)
> /* Adjust timezone to UTC0. */
> exfat_adjust_tz(ts, tz & ~EXFAT_TZ_VALID);
> else
> /* Convert from local time to UTC using time_offset. */
> ts->tv_sec -= sbi->options.time_offset * SECS_PER_MIN;
> }
>
> /* Convert linear UNIX date to a EXFAT time/date pair. */
> void exfat_set_entry_time(struct exfat_sb_info *sbi, struct timespec64 *ts,
> __le16 *time, __le16 *date, u8 *tz)
> {
> struct tm tm;
> u16 t, d;
>
> time64_to_tm(ts->tv_sec, 0, &tm);
> t = (tm.tm_hour << 11) | (tm.tm_min << 5) | (tm.tm_sec >> 1);
> d = ((tm.tm_year - 80) << 9) | ((tm.tm_mon + 1) << 5) | tm.tm_mday;
>
> *time = cpu_to_le16(t);
> *date = cpu_to_le16(d);
>
> /*
> * Record 00h value for OffsetFromUtc field and 1 value for OffsetValid
> * to indicate that local time and UTC are the same.
> */
> *tz = EXFAT_TZ_VALID;
> }
>
> Thanks!
>
next prev parent reply other threads:[~2020-01-17 10:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200115082818epcas1p4892a99345626188afd111ee263132458@epcas1p4.samsung.com>
2020-01-15 8:24 ` [PATCH v10 00/14] add the latest exfat driver Namjae Jeon
[not found] ` <CGME20200115082819epcas1p3303009557f8bf670b47991530f380ef7@epcas1p3.samsung.com>
2020-01-15 8:24 ` [PATCH v10 01/14] exfat: add in-memory and on-disk structures and headers Namjae Jeon
[not found] ` <CGME20200115082819epcas1p3825d5bed592a8378ad26254d07d59b18@epcas1p3.samsung.com>
2020-01-15 8:24 ` [PATCH v10 02/14] exfat: add super block operations Namjae Jeon
[not found] ` <CGME20200115082820epcas1p34ebebebaf610fd61c4e9882fca8ddbd5@epcas1p3.samsung.com>
2020-01-15 8:24 ` [PATCH v10 03/14] exfat: add inode operations Namjae Jeon
2020-01-15 10:25 ` Arnd Bergmann
2020-01-15 13:39 ` Namjae Jeon
2020-01-17 9:25 ` Pali Rohár
2020-01-17 11:17 ` Pali Rohár
[not found] ` <CGME20200115082821epcas1p3db1f70cf53185c40934c3a754c65e648@epcas1p3.samsung.com>
2020-01-15 8:24 ` [PATCH v10 04/14] exfat: add directory operations Namjae Jeon
2020-01-17 11:13 ` Pali Rohár
[not found] ` <CGME20200115082821epcas1p4d76d8668dfac70ae3e3889d4ccb6c3ee@epcas1p4.samsung.com>
2020-01-15 8:24 ` [PATCH v10 05/14] exfat: add file operations Namjae Jeon
2020-01-15 9:56 ` Arnd Bergmann
2020-01-15 13:07 ` Namjae Jeon
2020-01-17 9:18 ` Pali Rohár
2020-01-17 12:12 ` Namjae Jeon
[not found] ` <CGME20200115082822epcas1p37aca37dad0aa9159d7eddde01edfeec2@epcas1p3.samsung.com>
2020-01-15 8:24 ` [PATCH v10 06/14] exfat: add fat entry operations Namjae Jeon
[not found] ` <CGME20200115082822epcas1p384d080724d8bb0a8cd4c3e3015a0895c@epcas1p3.samsung.com>
2020-01-15 8:24 ` [PATCH v10 07/14] exfat: add bitmap operations Namjae Jeon
[not found] ` <CGME20200115082823epcas1p27ec5ff6d384f148d826529f573173b04@epcas1p2.samsung.com>
2020-01-15 8:24 ` [PATCH v10 08/14] exfat: add exfat cache Namjae Jeon
[not found] ` <CGME20200115082824epcas1p4eb45d088c2f88149acb94563c4a9b276@epcas1p4.samsung.com>
2020-01-15 8:24 ` [PATCH v10 09/14] exfat: add misc operations Namjae Jeon
2020-01-15 10:10 ` Arnd Bergmann
2020-01-15 13:30 ` Namjae Jeon
2020-01-15 13:38 ` Pali Rohár
2020-01-15 13:50 ` Arnd Bergmann
2020-01-15 14:24 ` Pali Rohár
2020-01-15 15:03 ` Arnd Bergmann
2020-01-15 15:39 ` Pali Rohár
2020-01-15 15:52 ` Arnd Bergmann
2020-01-16 10:19 ` Pali Rohár
2020-01-16 10:23 ` Christoph Hellwig
2020-01-16 16:00 ` Pali Rohár
2020-01-17 2:59 ` Namjae Jeon
2020-01-17 10:13 ` Arnd Bergmann [this message]
2020-01-17 12:13 ` Namjae Jeon
[not found] ` <CGME20200115082824epcas1p23a0fa255a5833c6dcd2479b384f37740@epcas1p2.samsung.com>
2020-01-15 8:24 ` [PATCH v10 10/14] exfat: add nls operations Namjae Jeon
[not found] ` <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com>
2020-01-15 8:24 ` [PATCH v10 11/14] exfat: add Kconfig and Makefile Namjae Jeon
2020-01-15 9:39 ` Pali Rohár
2020-01-17 4:22 ` Namjae Jeon
2020-01-17 9:12 ` Pali Rohár
2020-01-17 11:59 ` Namjae Jeon
[not found] ` <CGME20200115082825epcas1p4a0d63d53d8737a84fe8867bc1e63811e@epcas1p4.samsung.com>
2020-01-15 8:24 ` [PATCH v10 12/14] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
[not found] ` <CGME20200115082826epcas1p117191a39ecccaef5a9b5cbe77b05c5a5@epcas1p1.samsung.com>
2020-01-15 8:24 ` [PATCH v10 13/14] MAINTAINERS: add exfat filesystem Namjae Jeon
[not found] ` <CGME20200115082826epcas1p3475ce2b4d03234dc96ced428be582eb3@epcas1p3.samsung.com>
2020-01-15 8:24 ` [PATCH v10 14/14] staging: exfat: make staging/exfat and fs/exfat mutually exclusive Namjae Jeon
2020-01-15 8:56 ` Greg KH
2020-01-15 13:06 ` Namjae Jeon
2020-01-15 9:47 ` [PATCH v10 00/14] add the latest exfat driver Pali Rohár
2020-01-15 13:05 ` Namjae Jeon
2020-01-16 10:51 ` Christoph Hellwig
2020-01-16 11:32 ` Pali Rohár
2020-01-16 13:01 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a28NRp+SGr44=DTYqL0+ZqtamHwn+WYNTxVRJOJ3HtLSg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=pali.rohar@gmail.com \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).