From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-wr0-f194.google.com ([209.85.128.194]:33139 "EHLO
        mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753489AbeFKUPH (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 11 Jun 2018 16:15:07 -0400
Received: by mail-wr0-f194.google.com with SMTP id k16-v6so21727682wro.0
        for <linux-fsdevel@vger.kernel.org>; Mon, 11 Jun 2018 13:15:07 -0700 (PDT)
MIME-Version: 1.0
References: <20180528222013.18402-1-viro@ZenIV.linux.org.uk>
 <20180606225751.GA1261@outlook.office365.com> <20180607175622.GA12359@outlook.office365.com>
In-Reply-To: <20180607175622.GA12359@outlook.office365.com>
From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Mon, 11 Jun 2018 23:14:55 +0300
Message-ID: <CAM5jBj5Q5ZLURn_jqk+TQpDsLe6g7Ou-ju=sqdHBFjkHk=D-uw@mail.gmail.com>
Subject: Re: [1/4] vmsplice: lift import_iovec() into do_vmsplice()
To: Andrey Vagin <avagin@virtuozzo.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Jun 7, 2018 at 10:07 PM Andrei Vagin <avagin@virtuozzo.com> wrote:
>
...
> > > +
> > > +   error = import_iovec(READ, uiov, nr_segs,
> > > +                      ARRAY_SIZE(iovstack), &iov, &iter);
> >
> > import_iovec should be called with WRITE, if we are going to call
> > vmsplice_to_pipe().
>
> We caught this issue, when we run CRIU tests for
> https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/log/?h=for-next
>
> CRIU fails with errors like this:
>
> pie: 38: Error (criu/pie/parasite.c:89): Can't splice pages to pipe (-14/2/0)
>
It is already in the master tree, or still in the linux-next?