From: Muchun Song <songmuchun@bytedance.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: adobriyan@gmail.com, ast@kernel.org, daniel@iogearbox.net,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
john.fastabend@gmail.com, kpsingh@chromium.org,
ebiederm@xmission.com, bernd.edlinger@hotmail.de,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [External] Re: [PATCH] files: Use rcu lock to get the file structures for better performance
Date: Fri, 22 May 2020 15:52:39 +0800 [thread overview]
Message-ID: <CAMZfGtWn4xa-5-0rN2KJzUYioiOOUYX9BFcUDNZS85H11sYDEA@mail.gmail.com> (raw)
In-Reply-To: <20200521164746.GD28818@bombadil.infradead.org>
On Fri, May 22, 2020 at 12:47 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Thu, May 21, 2020 at 08:38:35PM +0800, Muchun Song wrote:
> > +++ b/fs/proc/fd.c
> > @@ -34,19 +34,27 @@ static int seq_show(struct seq_file *m, void *v)
> > if (files) {
> > unsigned int fd = proc_fd(m->private);
> >
> > - spin_lock(&files->file_lock);
> > + rcu_read_lock();
> > +again:
> > file = fcheck_files(files, fd);
> > if (file) {
> > - struct fdtable *fdt = files_fdtable(files);
> > + struct fdtable *fdt;
> > +
> > + if (!get_file_rcu(file)) {
> > + /*
> > + * we loop to catch the new file (or NULL
> > + * pointer).
> > + */
> > + goto again;
> > + }
> >
> > + fdt = files_fdtable(files);
>
> This is unusual, and may not be safe.
>
> fcheck_files() loads files->fdt. Then it loads file from fdt->fd[].
> Now you're loading files->fdt again here, and it could have been changed
> by another thread expanding the fd table.
>
> You have to write a changelog which convinces me you've thought about
> this race and that it's safe. Because I don't think you even realise
> it's a possibility at this point.
Thanks for your review, it is a problem. I can fix it.
>
> > @@ -160,14 +168,23 @@ static int proc_fd_link(struct dentry *dentry, struct path *path)
> > unsigned int fd = proc_fd(d_inode(dentry));
> > struct file *fd_file;
> >
> > - spin_lock(&files->file_lock);
> > + rcu_read_lock();
> > +again:
> > fd_file = fcheck_files(files, fd);
> > if (fd_file) {
> > + if (!get_file_rcu(fd_file)) {
> > + /*
> > + * we loop to catch the new file
> > + * (or NULL pointer).
> > + */
> > + goto again;
> > + }
> > *path = fd_file->f_path;
> > path_get(&fd_file->f_path);
> > + fput(fd_file);
> > ret = 0;
> > }
> > - spin_unlock(&files->file_lock);
> > + rcu_read_unlock();
>
> Why is it an improvement to increment/decrement the refcount on the
> struct file here, rather than take/release the spinlock?
>
lock-free vs spinlock.
Do you think spinlock would be better than the lock-free method?
Actually I prefer the rcu lock.
--
Yours,
Muchun
next prev parent reply other threads:[~2020-05-22 7:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 12:38 [PATCH] files: Use rcu lock to get the file structures for better performance Muchun Song
2020-05-21 15:21 ` Matthew Wilcox
2020-05-21 16:06 ` [External] " Muchun Song
2020-05-21 16:16 ` Greg KH
2020-05-21 16:47 ` Matthew Wilcox
2020-05-22 7:52 ` Muchun Song [this message]
2020-05-22 11:43 ` [External] " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZfGtWn4xa-5-0rN2KJzUYioiOOUYX9BFcUDNZS85H11sYDEA@mail.gmail.com \
--to=songmuchun@bytedance.com \
--cc=adobriyan@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bernd.edlinger@hotmail.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ebiederm@xmission.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=willy@infradead.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).