From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter
Date: Fri, 3 Jul 2020 07:56:43 +0200 [thread overview]
Message-ID: <CANiq72=8facdt7HBtoUZiJW5zfki-gYYESJzxjXf7wK7dYLm1Q@mail.gmail.com> (raw)
In-Reply-To: <20200702135054.GA29240@lst.de>
On Thu, Jul 2, 2020 at 3:50 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Do you have a suggestion for an automated replacement which does?
> I'll happily switch over to that.
I guess I'd simply find the unique set of cases that occur and create
a replacement for each manually. A handful of them or so may already
cover the majority of cases. CC'ing Joe since he deals with this sort
of stuff all the time.
Some cannot be handled with replacements, e.g. re-aligning the full
list is required to fit the longer `_iter` -- if you want to cover
those cases too, applying `clang-format` to the initializer may be a
good approach.
Cheers,
Miguel
next prev parent reply other threads:[~2020-07-03 5:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 20:09 [RFC] stop using ->read and ->write for kernel access v3 Christoph Hellwig
2020-07-01 20:09 ` [PATCH 01/23] cachefiles: switch to kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 02/23] autofs: " Christoph Hellwig
2020-07-01 20:09 ` [PATCH 03/23] bpfilter: " Christoph Hellwig
2020-07-01 20:09 ` [PATCH 04/23] fs: unexport __kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 05/23] fs: check FMODE_WRITE in __kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 06/23] fs: implement kernel_write using __kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 07/23] fs: remove __vfs_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 08/23] fs: don't change the address limit for ->write_iter in __kernel_write Christoph Hellwig
2020-07-01 20:09 ` [PATCH 09/23] fs: add a __kernel_read helper Christoph Hellwig
2020-07-01 20:09 ` [PATCH 10/23] integrity/ima: switch to using __kernel_read Christoph Hellwig
2020-07-01 20:09 ` [PATCH 11/23] fs: implement kernel_read " Christoph Hellwig
2020-07-01 20:09 ` [PATCH 12/23] fs: remove __vfs_read Christoph Hellwig
2020-07-01 20:09 ` [PATCH 13/23] fs: don't change the address limit for ->read_iter in __kernel_read Christoph Hellwig
2020-07-01 20:09 ` [PATCH 14/23] fs: refactor new_sync_read Christoph Hellwig
2020-07-01 20:09 ` [PATCH 15/23] seq_file: add seq_read_iter Christoph Hellwig
2020-07-01 20:09 ` [PATCH 17/23] proc: add a read_iter method to proc proc_ops Christoph Hellwig
2020-07-01 21:27 ` Al Viro
2020-07-02 5:18 ` Christoph Hellwig
2020-07-02 7:30 ` Christoph Hellwig
2020-07-01 20:09 ` [PATCH 18/23] proc: switch over direct seq_read method calls to seq_read_iter Christoph Hellwig
2020-07-01 20:09 ` [PATCH 19/23] sysctl: Call sysctl_head_finish on error Christoph Hellwig
2020-07-02 0:32 ` Matthew Wilcox
2020-07-02 5:15 ` Christoph Hellwig
2020-07-03 1:34 ` Al Viro
2020-07-01 20:09 ` [PATCH 20/23] sysctl: Convert to iter interfaces Christoph Hellwig
2020-07-01 20:09 ` [PATCH 21/23] fs: don't allow kernel reads and writes without iter ops Christoph Hellwig
2020-07-01 20:09 ` [PATCH 22/23] fs: default to generic_file_splice_read for files having ->read_iter Christoph Hellwig
2020-07-01 20:09 ` [PATCH 23/23] fs: don't allow splice read/write without explicit ops Christoph Hellwig
[not found] ` <20200701200951.3603160-17-hch@lst.de>
2020-07-02 9:46 ` [PATCH 16/23] seq_file: switch over direct seq_read method calls to seq_read_iter Miguel Ojeda
2020-07-02 13:50 ` Christoph Hellwig
2020-07-03 5:56 ` Miguel Ojeda [this message]
2020-07-03 7:44 ` Joe Perches
2020-07-03 9:35 ` Miguel Ojeda
2020-07-03 9:43 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72=8facdt7HBtoUZiJW5zfki-gYYESJzxjXf7wK7dYLm1Q@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).