Re: [PATCH v2] ovl: require xwhiteout feature flag on layer roots

From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
	linux-unionfs@vger.kernel.org,
	 Alexander Larsson <alexl@redhat.com>,
	linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] ovl: require xwhiteout feature flag on layer roots
Date: Fri, 19 Jan 2024 14:19:38 +0200	[thread overview]
Message-ID: <CAOQ4uxhVwnhOLxbfAjeGkwXA2iOz=-BXZNKUtY29UN_zTDtfCg@mail.gmail.com> (raw)
In-Reply-To: <CAJfpegteroc6yJAmjh=MaqZOO9Q7ZJfg5BgMJFN3wdHGZK6gGw@mail.gmail.com>

On Fri, Jan 19, 2024 at 1:20 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> On Fri, 19 Jan 2024 at 12:08, Amir Goldstein <amir73il@gmail.com> wrote:
>
> > > @@ -577,6 +580,8 @@ static int ovl_dir_read_impure(const struct path *path,  struct list_head *list,
> > >         INIT_LIST_HEAD(list);
> > >         *root = RB_ROOT;
> > >         ovl_path_upper(path->dentry, &realpath);
> > > +       if (ovl_path_check_xwhiteouts_xattr(ofs, &ofs->layers[0], &realpath))
> > > +               rdd.in_xwhiteouts_dir = true;
> >
> > Not needed since we do not support xwhiteouts on upper.
>
> Right.
>
> > > @@ -1079,6 +1090,8 @@ static int ovl_get_layers(struct super_block *sb, struct ovl_fs *ofs,
> > >                 l->name = NULL;
> > >                 ofs->numlayer++;
> > >                 ofs->fs[fsid].is_lower = true;
> > > +
> > > +
> >
> > extra spaces.
>
> Sorry, missing self review...
>
> > Do you want me to fix/test and send this to Linus?
>
> Yes please, if it's not a problem four you.
>

ok. queued.

Thanks,
Amir.