From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Matthew Bobrowski <mbobrowski@mbobrowski.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v4 04/10] fsnotify: send event with parent/name info to sb/mount/non-dir marks
Date: Tue, 14 Jul 2020 18:31:11 +0300 [thread overview]
Message-ID: <CAOQ4uxi2aS_XnQcX1t54VekUF49aWC8mNgjb2L9JdBhjTAPBoA@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxjKj=S6s_L2m4d65PEha+H-MCHUmiozx42NAs1K40ZfXw@mail.gmail.com>
> > > + const struct path *path = fsnotify_data_path(data, data_type);
> > > + struct mount *mnt = path ? real_mount(path->mnt) : NULL;
> > > struct inode *inode = d_inode(dentry);
> > > struct dentry *parent;
> > > + bool parent_watched = dentry->d_flags & DCACHE_FSNOTIFY_PARENT_WATCHED;
> > > + __u32 p_mask, test_mask, marks_mask = 0;
> > > struct inode *p_inode;
> > > int ret = 0;
> > >
> > > + /*
> > > + * Do inode/sb/mount care about parent and name info on non-dir?
> > > + * Do they care about any event at all?
> > > + */
> > > + if (!inode->i_fsnotify_marks && !inode->i_sb->s_fsnotify_marks &&
> > > + (!mnt || !mnt->mnt_fsnotify_marks)) {
> > > + if (!parent_watched)
> > > + return 0;
> > > + } else if (!(mask & FS_ISDIR) && !IS_ROOT(dentry)) {
> > > + marks_mask |= fsnotify_want_parent(inode->i_fsnotify_mask);
> > > + marks_mask |= fsnotify_want_parent(inode->i_sb->s_fsnotify_mask);
> > > + if (mnt)
> > > + marks_mask |= fsnotify_want_parent(mnt->mnt_fsnotify_mask);
> > > + }
> >
> > OK, so AFAIU at this point (mask & marks_mask) tells us whether we need to
> > grab parent because some mark needs parent into reported. Correct?
> >
> > Maybe I'd rename fsnotify_want_parent() (which seems like it returns bool)
> > to fsnotify_parent_needed_mask() or something like that. Also I'd hide all
> > those checks in a helper function like:
> >
> > fsnotify_event_needs_parent(mnt, inode, mask)
> >
> > So we'd then have just something like:
> > if (!inode->i_fsnotify_marks && !inode->i_sb->s_fsnotify_marks &&
> > (!mnt || !mnt->mnt_fsnotify_marks) && !parent_watched)
> > return 0;
> > if (!parent_watched && !fsnotify_event_needs_parent(mnt, inode, mask))
> > goto notify_child;
>
> OK, but we'd still need to store marks_mask for later in case event
> needs parent.
>
Nevermind, I understand now what you meant.
Changed the function according to your guidance and looks much better.
Fits now in one terminal screen :-)
>
> > ...
> >
> > > +
> > > parent = NULL;
> > > - if (!(dentry->d_flags & DCACHE_FSNOTIFY_PARENT_WATCHED))
> > > + test_mask = mask & FS_EVENTS_POSS_TO_PARENT;
> > > + if (!(marks_mask & test_mask) && !parent_watched)
> > > goto notify_child;
> > >
> > > + /* Does parent inode care about events on children? */
> > > parent = dget_parent(dentry);
> > > p_inode = parent->d_inode;
> > > + p_mask = fsnotify_inode_watches_children(p_inode);
> > >
> > > - if (unlikely(!fsnotify_inode_watches_children(p_inode))) {
> > > + if (p_mask)
> > > + marks_mask |= p_mask;
> > > + else if (unlikely(parent_watched))
> > > __fsnotify_update_child_dentry_flags(p_inode);
> > > - } else if (p_inode->i_fsnotify_mask & mask & ALL_FSNOTIFY_EVENTS) {
> > > +
> > > + if ((marks_mask & test_mask) && p_inode != inode) {
> > ^^ this is effectively
> > !IS_ROOT(dentry), isn't it? But since you've checked that above can it ever
> > be that p_inode == inode?
> >
>
> True, but only if you add the hidden assumption (which should be true) that
> DCACHE_FSNOTIFY_PARENT_WATCHED cannot be set on an IS_ROOT
> dentry. Otherwise you can have parent_watched and not check IS_ROOT()
> so prefered defensive here, but I don't mind dropping it.
>
I dropped this and also dropped the IS_ROOT(dentry) check because
there is already a check in the inline fsnotify_parent().
FYI, pushed these changes to branch fsnotify_name.
Rebased/tested/pushed branch fanotify_name_fid on top.
There are no changes to following patches as they are all
fanotify patches.
Thanks,
Amir.
next prev parent reply other threads:[~2020-07-14 15:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 12:57 [PATCH v4 00/10] fanotify events with name info Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 01/10] inotify: report both events on parent and child with single callback Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 02/10] fanotify: " Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 03/10] fsnotify: send event to " Amir Goldstein
2020-07-14 10:34 ` Jan Kara
2020-07-14 11:54 ` Amir Goldstein
2020-07-15 17:09 ` Jan Kara
2020-07-15 17:42 ` Amir Goldstein
2020-07-16 6:38 ` Amir Goldstein
2020-07-16 7:39 ` Amir Goldstein
2020-07-16 9:55 ` Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 04/10] fsnotify: send event with parent/name info to sb/mount/non-dir marks Amir Goldstein
2020-07-14 11:54 ` Jan Kara
2020-07-14 12:17 ` Amir Goldstein
2020-07-14 15:31 ` Amir Goldstein [this message]
2020-07-02 12:57 ` [PATCH v4 05/10] fsnotify: send MOVE_SELF event with parent/name info Amir Goldstein
2020-07-14 12:13 ` Jan Kara
2020-07-14 12:44 ` Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 06/10] fanotify: add basic support for FAN_REPORT_DIR_FID Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 07/10] fanotify: report events with parent dir fid to sb/mount/non-dir marks Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 08/10] fanotify: add support for FAN_REPORT_NAME Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 09/10] fanotify: report parent fid + name + child fid Amir Goldstein
2020-07-02 12:57 ` [PATCH v4 10/10] fanotify: report parent fid " Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxi2aS_XnQcX1t54VekUF49aWC8mNgjb2L9JdBhjTAPBoA@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).