From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f179.google.com ([209.85.213.179]:40530 "EHLO mail-yb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388481AbeGKOVf (ORCPT ); Wed, 11 Jul 2018 10:21:35 -0400 Received: by mail-yb0-f179.google.com with SMTP id y11-v6so10047493ybm.7 for ; Wed, 11 Jul 2018 07:17:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180710100217.12866-11-jack@suse.cz> References: <20180710100217.12866-1-jack@suse.cz> <20180710100217.12866-11-jack@suse.cz> From: Amir Goldstein Date: Wed, 11 Jul 2018 17:17:01 +0300 Message-ID: Subject: Re: [PATCH 10/10] audit: Replace chunk attached to mark instead of replacing mark To: Jan Kara Cc: Linux Audit , Paul Moore , linux-fsdevel , Al Viro , Richard Guy Briggs Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jul 10, 2018 at 1:02 PM, Jan Kara wrote: > Audit tree code currently associates new fsnotify mark with each new > chunk. As chunk attached to an inode is replaced when new tag is added / > removed, we also need to remove old fsnotify mark and add a new one on > such occasion. This is cumbersome and makes locking rules somewhat > difficult to follow. > > Fix these problems by allocating fsnotify mark independently of chunk > and keeping it all the time while there is some chunk attached to an > inode. Also add documentation about the locking rules so that things are > easier to follow. > > Signed-off-by: Jan Kara > --- Well, if there are bugs here I can't find them, but they sure have a lot of places to hide... Cheers, Amir.