From: Amir Goldstein <amir73il@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Henry Wilson <henry.wilson@acentic.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: [PATCH v3 4.17] inotify: Add flag IN_EXCL_ADD for inotify_add_watch()
Date: Wed, 30 May 2018 22:03:35 +0300 [thread overview]
Message-ID: <CAOQ4uxj4c0T6iE7eNy+89EFARreJLLT0WDPBVONSkk-MxA300w@mail.gmail.com> (raw)
In-Reply-To: <20180530160427.qs2dykrx3ohqm3bf@quack2.suse.cz>
On Wed, May 30, 2018 at 7:04 PM, Jan Kara <jack@suse.cz> wrote:
> On Wed 30-05-18 18:40:27, Amir Goldstein wrote:
>> On Wed, May 30, 2018 at 4:35 PM, Henry Wilson <henry.wilson@acentic.com> wrote:
>> > On 30/05/18 14:01, Jan Kara wrote:
>> >>
>> >> Thanks. The patch looks good. I've added it to my tree. BTW, do you plan
>> >> on
>> >> working on a similar addition to fanotify?
>> >>
>> >> Honza
>> >>
>> >
>> > Ah that's grand, I'm glad to have helped to improve things.
>> > I'm not familiar with fanotify, however a quick look at fanotify_user.c
>> > suggests that a similar approach may be taken by modifying:
>> >
>> > if(!fsn_mark) {
>> > ...
>> > }
>> > else if (create) {
>> > return -EEXIST;
>> > }
>> >
>> > in both fanotify_add_vfsmount_mark() and fanotify_add_inode_mark()
>> >
>>
>> I think that was a yes/no question and I interpret your answer as no??
>>
>> Anyway, another yes/no question:
>> Can you write a simple LTP test to verify the new API?
>>
>> I reccon Jan was also expecting an actual patch posted to man pages
>> maintainer (and linux-api, which was not cc'ed on the latest patch).
>
> Yes, and I think Henry is about to post it, just didn't get to it yet.
>
>> About the fanotify change, since fanotify API does have 'flags' separate
>> from 'mask', I am not sure if FAN_MARK_EXCL_ADD would be the
>> best flag name?? Perhaps FAN_MARK_CREATE? FAN_MARK_NEW?
>> not sure.
>
> Yes, for fanotify we could choose a different name.
>
>> But also, I did not get a chance to comment about the chosen inotify
>> flag name that the lexical proximity to IN_EXCL_UNLINK is a bit odd
>> considering that _EXCL_ mean two completely different things.
>>
>> Should we maybe re-consider the chosen flag name?
>
> I'm open to that, I have the patch just sitting in an internal branch for
> now. Do you have a better suggestion? Maybe since we already have
> IN_MASK_ADD, we could call it IN_MASK_CREATE? And then FAN_MARK_CREATE for
> fanotify_mark(2)?
>
I like that naming.
Thinking forward, since we don't have many reserved bits left in inotify mask,
we should return -EINVAL for both IN_MASK_ADD and IN_MASK_CREATE
(they don't make sense together anyway), so we may re purpose the flag
combination in the future for something else.
Thanks,
Amir.
next prev parent reply other threads:[~2018-05-30 19:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 15:24 [PATCH 4.17] inotify: Add flag IN_ONLY_CREATE for inotify_add_watch() Henry Wilson
2018-05-03 19:42 ` Amir Goldstein
2018-05-04 8:44 ` Henry Wilson
2018-05-16 10:44 ` [PATCH v2 4.17] From: Henry Wilson <henry.wilson@acentic.com> henry.wilson
2018-05-29 9:15 ` Jan Kara
2018-05-29 11:03 ` Henry Wilson
2018-05-29 12:15 ` Jan Kara
2018-05-30 11:00 ` Henry Wilson
2018-05-30 10:26 ` [PATCH v3 4.17] inotify: Add flag IN_EXCL_ADD for inotify_add_watch() henry.wilson
2018-05-30 13:01 ` Jan Kara
2018-05-30 13:35 ` Henry Wilson
2018-05-30 15:40 ` Amir Goldstein
2018-05-30 16:04 ` Jan Kara
2018-05-30 19:03 ` Amir Goldstein [this message]
2018-05-31 9:42 ` Jan Kara
2018-05-31 8:22 ` Henry Wilson
2018-05-31 10:24 ` Amir Goldstein
2018-05-30 16:10 ` Randy Dunlap
2018-05-31 9:43 ` [PATCH v4 4.17] inotify: Add flag IN_MASK_CREATE " henry.wilson
2018-05-31 10:38 ` Amir Goldstein
2018-05-31 11:43 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxj4c0T6iE7eNy+89EFARreJLLT0WDPBVONSkk-MxA300w@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=henry.wilson@acentic.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).