From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Luis Chamberlain" <mcgrof@kernel.org>, <keescook@chromium.org>,
<yzaikin@google.com>, <dhowells@redhat.com>,
<paul@paul-moore.com>, <jmorris@namei.org>, <serge@hallyn.com>,
<j.granados@samsung.com>, <brauner@kernel.org>
Cc: <ebiederm@xmission.com>, <patches@lists.linux.dev>,
<linux-fsdevel@vger.kernel.org>, <keyrings@vger.kernel.org>,
<linux-security-module@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] sysctl: move security keys sysctl registration to its own file
Date: Tue, 06 Jun 2023 23:39:15 +0300 [thread overview]
Message-ID: <CT5UVNZYSAPZ.1PJWWUUOCHODW@suppilovahvero> (raw)
In-Reply-To: <20230530232914.3689712-3-mcgrof@kernel.org>
On Wed May 31, 2023 at 2:29 AM EEST, Luis Chamberlain wrote:
> The security keys sysctls are already declared on its own file,
> just move the sysctl registration to its own file to help avoid
> merge conflicts on sysctls.c, and help with clearing up sysctl.c
> further.
>
> This creates a small penalty of 23 bytes:
>
> ./scripts/bloat-o-meter vmlinux.1 vmlinux.2
> add/remove: 2/0 grow/shrink: 0/1 up/down: 49/-26 (23)
> Function old new delta
> init_security_keys_sysctls - 33 +33
> __pfx_init_security_keys_sysctls - 16 +16
> sysctl_init_bases 85 59 -26
> Total: Before=21256937, After=21256960, chg +0.00%
>
> But soon we'll be saving tons of bytes anyway, as we modify the
> sysctl registrations to use ARRAY_SIZE and so we get rid of all the
> empty array elements so let's just clean this up now.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
> include/linux/key.h | 3 ---
> kernel/sysctl.c | 4 ----
> security/keys/sysctl.c | 7 +++++++
> 3 files changed, 7 insertions(+), 7 deletions(-)
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
next prev parent reply other threads:[~2023-06-06 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 23:29 [PATCH 0/2] sysctl: move umh and keys sysctls Luis Chamberlain
2023-05-30 23:29 ` [PATCH 1/2] sysctl: move umh sysctl registration to its own file Luis Chamberlain
2023-06-06 20:37 ` Jarkko Sakkinen
2023-05-30 23:29 ` [PATCH 2/2] sysctl: move security keys " Luis Chamberlain
2023-05-31 21:20 ` Paul Moore
2023-06-06 18:45 ` Luis Chamberlain
2023-06-06 20:39 ` Jarkko Sakkinen [this message]
2023-06-07 8:36 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CT5UVNZYSAPZ.1PJWWUUOCHODW@suppilovahvero \
--to=jarkko@kernel.org \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=j.granados@samsung.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=patches@lists.linux.dev \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).