From: Alessio Balsini <balsini@android.com>
To: "wu-yan@tcl.com" <wu-yan@tcl.com>
Cc: balsini@android.com, akailash@google.com, amir73il@gmail.com,
axboe@kernel.dk, duostefano93@gmail.com, dvander@google.com,
fuse-devel@lists.sourceforge.net, gscrivan@redhat.com,
jannh@google.com, kernel-team@android.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
maco@android.com, miklos@szeredi.hu, palmer@dabbelt.com,
paullawrence@google.com, trapexit@spawn.link,
zezeozue@google.com
Subject: Re: [PATCH V10 2/5] fuse: Passthrough initialization and release
Date: Wed, 16 Dec 2020 16:55:10 +0000 [thread overview]
Message-ID: <X9o77i1T4PDgm4q4@google.com> (raw)
In-Reply-To: <3bf58b6f-c7eb-7baa-384d-ae0830d8bceb@tcl.com>
On Wed, Dec 16, 2020 at 09:32:51PM +0800, wu-yan@tcl.com wrote:
> Hi Alessio,
>
> It may cause file reference counter leak in fuse_passthrough_open. If the
> passthrough_filp
>
> not implement read_iter/write_iter or passthrough struct allocated failed,
> the reference counter get in fget(pro->fd) not released and cause leak.
>
> Cheers,
>
> yanwu
>
Hi yanwu,
Nice catch, this bug was introduced in v10 and will be fixed in the next
patch set.
Cheers,
Alessio
next prev parent reply other threads:[~2020-12-16 16:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 12:50 [PATCH V10 0/5] fuse: Add support for passthrough read/write Alessio Balsini
2020-10-26 12:50 ` [PATCH V10 1/5] fuse: Definitions and ioctl() for passthrough Alessio Balsini
2020-10-26 12:50 ` [PATCH V10 2/5] fuse: Passthrough initialization and release Alessio Balsini
2020-11-26 13:33 ` Peng Tao
2020-11-27 13:41 ` Alessio Balsini
2020-11-28 1:57 ` Peng Tao
2020-12-16 16:46 ` Alessio Balsini
[not found] ` <3bf58b6f-c7eb-7baa-384d-ae0830d8bceb@tcl.com>
2020-12-16 16:55 ` Alessio Balsini [this message]
2020-10-26 12:50 ` [PATCH V10 3/5] fuse: Introduce synchronous read and write for passthrough Alessio Balsini
2020-10-26 12:50 ` [PATCH V10 4/5] fuse: Handle asynchronous read and write in passthrough Alessio Balsini
2020-10-26 12:50 ` [PATCH V10 5/5] fuse: Use daemon creds in passthrough mode Alessio Balsini
2020-11-28 2:10 ` [PATCH V10 0/5] fuse: Add support for passthrough read/write Peng Tao
2020-11-30 11:08 ` Alessio Balsini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9o77i1T4PDgm4q4@google.com \
--to=balsini@android.com \
--cc=akailash@google.com \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=duostefano93@gmail.com \
--cc=dvander@google.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=gscrivan@redhat.com \
--cc=jannh@google.com \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=miklos@szeredi.hu \
--cc=palmer@dabbelt.com \
--cc=paullawrence@google.com \
--cc=trapexit@spawn.link \
--cc=wu-yan@tcl.com \
--cc=zezeozue@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).