From: Daniel Vetter <daniel@ffwll.ch>
To: Kenny Ho <y2kenny@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Dave Airlie <airlied@gmail.com>, Kenny Ho <Kenny.Ho@amd.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Brian Welty <brian.welty@intel.com>
Subject: Re: [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL
Date: Fri, 7 May 2021 10:59:38 +0200 [thread overview]
Message-ID: <YJUBer3wWKSAeXe7@phenom.ffwll.local> (raw)
In-Reply-To: <CAOWid-fL0=OM2XiOH+NFgn_e2L4Yx8sXA-+HicUb9bzhP0t8Bw@mail.gmail.com>
On Thu, May 06, 2021 at 10:06:32PM -0400, Kenny Ho wrote:
> Sorry for the late reply (I have been working on other stuff.)
>
> On Fri, Feb 5, 2021 at 8:49 AM Daniel Vetter <daniel@ffwll.ch> wrote:
> >
> > So I agree that on one side CU mask can be used for low-level quality
> > of service guarantees (like the CLOS cache stuff on intel cpus as an
> > example), and that's going to be rather hw specific no matter what.
> >
> > But my understanding of AMD's plans here is that CU mask is the only
> > thing you'll have to partition gpu usage in a multi-tenant environment
> > - whether that's cloud or also whether that's containing apps to make
> > sure the compositor can still draw the desktop (except for fullscreen
> > ofc) doesn't really matter I think.
> This is not correct. Even in the original cgroup proposal, it
> supports both mask and count as a way to define unit(s) of sub-device.
> For AMD, we already have SRIOV that supports GPU partitioning in a
> time-sliced-of-a-whole-GPU fashion.
Hm I missed that. I feel like time-sliced-of-a-whole gpu is the easier gpu
cgroups controler to get started, since it's much closer to other cgroups
that control bandwidth of some kind. Whether it's i/o bandwidth or compute
bandwidht is kinda a wash.
CU mask feels a lot more like an isolation/guaranteed forward progress
kind of thing, and I suspect that's always going to be a lot more gpu hw
specific than anything we can reasonably put into a general cgroups
controller.
Also for the time slice cgroups thing, can you pls give me pointers to
these old patches that had it, and how it's done? I very obviously missed
that part.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2021-05-07 8:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 15:23 [RFC] Add BPF_PROG_TYPE_CGROUP_IOCTL Kenny Ho
2020-11-02 19:23 ` Kenny Ho
2020-11-03 5:32 ` Alexei Starovoitov
2020-11-03 5:39 ` Kenny Ho
2020-11-03 5:42 ` Alexei Starovoitov
2020-11-03 19:19 ` Kenny Ho
2020-11-03 21:04 ` Alexei Starovoitov
2020-11-03 22:57 ` Kenny Ho
2020-11-03 23:28 ` Alexei Starovoitov
2021-02-01 14:49 ` Daniel Vetter
2021-02-01 16:51 ` Kenny Ho
2021-02-03 11:09 ` Daniel Vetter
2021-02-03 19:01 ` Kenny Ho
2021-02-05 13:49 ` Daniel Vetter
2021-05-07 2:06 ` Kenny Ho
2021-05-07 8:59 ` Daniel Vetter [this message]
2021-05-07 15:33 ` Kenny Ho
2021-05-07 16:13 ` Daniel Vetter
2021-05-07 16:19 ` Alex Deucher
2021-05-07 16:26 ` Daniel Vetter
2021-05-07 16:31 ` Alex Deucher
2021-05-07 16:50 ` Alex Deucher
2021-05-07 16:54 ` Daniel Vetter
2021-05-07 17:04 ` Kenny Ho
2021-05-07 19:33 ` Tejun Heo
2021-05-07 19:55 ` Alex Deucher
2021-05-07 20:59 ` Tejun Heo
2021-05-07 22:30 ` Alex Deucher
2021-05-07 23:45 ` Tejun Heo
2021-05-11 15:48 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJUBer3wWKSAeXe7@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Kenny.Ho@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexei.starovoitov@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brian.welty@intel.com \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=viro@zeniv.linux.org.uk \
--cc=y2kenny@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).