From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: vgoyal@redhat.com, stefanha@redhat.com, miklos@szeredi.hu,
linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
joseph.qi@linux.alibaba.com,
virtualization@lists.linux-foundation.org
Subject: Re: [Virtio-fs] [PATCH v4 6/8] fuse: mark inode DONT_CACHE when per-file DAX indication changes
Date: Tue, 17 Aug 2021 11:26:45 +0100 [thread overview]
Message-ID: <YRuO5ZzqDmuSC3pN@work-vm> (raw)
In-Reply-To: <20210817022220.17574-7-jefflexu@linux.alibaba.com>
* Jeffle Xu (jefflexu@linux.alibaba.com) wrote:
> When the per-file DAX indication changes while the file is still
> *opened*, it is quite complicated and maybe fragile to dynamically
> change the DAX state.
>
> Hence mark the inode and corresponding dentries as DONE_CACHE once the
^^^^^^^^^^
typo as DONT ?
Dave
> per-file DAX indication changes, so that the inode instance will be
> evicted and freed as soon as possible once the file is closed and the
> last reference to the inode is put. And then when the file gets reopened
> next time, the inode will reflect the new DAX state.
>
> In summary, when the per-file DAX indication changes for an *opened*
> file, the state of the file won't be updated until this file is closed
> and reopened later.
>
> Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com>
> ---
> fs/fuse/dax.c | 9 +++++++++
> fs/fuse/fuse_i.h | 1 +
> fs/fuse/inode.c | 3 +++
> 3 files changed, 13 insertions(+)
>
> diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c
> index 30833f8d37dd..f7ede0be4e00 100644
> --- a/fs/fuse/dax.c
> +++ b/fs/fuse/dax.c
> @@ -1364,6 +1364,15 @@ void fuse_dax_inode_init(struct inode *inode, unsigned int flags)
> inode->i_data.a_ops = &fuse_dax_file_aops;
> }
>
> +void fuse_dax_dontcache(struct inode *inode, bool newdax)
> +{
> + struct fuse_conn *fc = get_fuse_conn(inode);
> +
> + if (fc->dax_mode == FUSE_DAX_INODE &&
> + fc->perfile_dax && (!!IS_DAX(inode) != newdax))
> + d_mark_dontcache(inode);
> +}
> +
> bool fuse_dax_check_alignment(struct fuse_conn *fc, unsigned int map_alignment)
> {
> if (fc->dax && (map_alignment > FUSE_DAX_SHIFT)) {
> diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h
> index 7b7b4c208af2..56fe1c4d2136 100644
> --- a/fs/fuse/fuse_i.h
> +++ b/fs/fuse/fuse_i.h
> @@ -1260,6 +1260,7 @@ void fuse_dax_conn_free(struct fuse_conn *fc);
> bool fuse_dax_inode_alloc(struct super_block *sb, struct fuse_inode *fi);
> void fuse_dax_inode_init(struct inode *inode, unsigned int flags);
> void fuse_dax_inode_cleanup(struct inode *inode);
> +void fuse_dax_dontcache(struct inode *inode, bool newdax);
> bool fuse_dax_check_alignment(struct fuse_conn *fc, unsigned int map_alignment);
> void fuse_dax_cancel_work(struct fuse_conn *fc);
>
> diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> index 8080f78befed..8c9774c6a210 100644
> --- a/fs/fuse/inode.c
> +++ b/fs/fuse/inode.c
> @@ -269,6 +269,9 @@ void fuse_change_attributes(struct inode *inode, struct fuse_attr *attr,
> if (inval)
> invalidate_inode_pages2(inode->i_mapping);
> }
> +
> + if (IS_ENABLED(CONFIG_FUSE_DAX))
> + fuse_dax_dontcache(inode, attr->flags & FUSE_ATTR_DAX);
> }
>
> static void fuse_init_inode(struct inode *inode, struct fuse_attr *attr)
> --
> 2.27.0
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://listman.redhat.com/mailman/listinfo/virtio-fs
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-08-17 10:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 2:22 [PATCH v4 0/8] fuse,virtiofs: support per-file DAX Jeffle Xu
2021-08-17 2:22 ` [PATCH v4 1/8] fuse: add fuse_should_enable_dax() helper Jeffle Xu
2021-08-17 2:22 ` [PATCH v4 2/8] fuse: Make DAX mount option a tri-state Jeffle Xu
2021-08-17 2:22 ` [PATCH v4 3/8] fuse: support per-file DAX Jeffle Xu
2021-08-17 2:22 ` [PATCH v4 4/8] fuse: negotiate if server/client supports " Jeffle Xu
2021-08-17 2:22 ` [PATCH v4 5/8] fuse: enable " Jeffle Xu
2021-08-17 2:22 ` [PATCH v4 6/8] fuse: mark inode DONT_CACHE when per-file DAX indication changes Jeffle Xu
2021-08-17 10:26 ` Dr. David Alan Gilbert [this message]
2021-08-17 13:23 ` [Virtio-fs] " JeffleXu
2021-08-17 2:22 ` [PATCH v4 7/8] fuse: support changing per-file DAX flag inside guest Jeffle Xu
2021-08-17 2:22 ` [PATCH v4 8/8] fuse: show '-o dax=inode' option only when FUSE server supports Jeffle Xu
2021-08-17 2:23 ` [virtiofsd PATCH v4 0/4] virtiofsd: support per-file DAX Jeffle Xu
2021-08-17 2:23 ` [virtiofsd PATCH v4 1/4] virtiofsd: add .ioctl() support Jeffle Xu
2021-08-18 17:33 ` Vivek Goyal
2021-08-17 2:23 ` [virtiofsd PATCH v4 2/4] virtiofsd: expand fuse protocol to support per-file DAX Jeffle Xu
2021-08-17 2:23 ` [virtiofsd PATCH v4 3/4] virtiofsd: support per-file DAX negotiation in FUSE_INIT Jeffle Xu
2021-08-17 17:15 ` [Virtio-fs] " Dr. David Alan Gilbert
2021-08-18 5:28 ` JeffleXu
2021-08-19 13:57 ` Dr. David Alan Gilbert
2021-08-18 17:30 ` Vivek Goyal
2021-08-17 2:23 ` [virtiofsd PATCH v4 4/4] virtiofsd: support per-file DAX in FUSE_LOOKUP Jeffle Xu
2021-08-17 19:00 ` [Virtio-fs] " Dr. David Alan Gilbert
2021-08-18 5:46 ` JeffleXu
2021-08-19 13:08 ` Dr. David Alan Gilbert
2021-08-20 5:03 ` JeffleXu
2021-08-24 10:15 ` Greg Kurz
2021-09-08 10:34 ` JeffleXu
2021-08-17 8:06 ` [PATCH v4 0/8] fuse,virtiofs: support per-file DAX Miklos Szeredi
2021-08-17 9:32 ` [Virtio-fs] " Dr. David Alan Gilbert
2021-08-17 10:09 ` Miklos Szeredi
2021-08-17 10:37 ` Dr. David Alan Gilbert
2021-08-17 13:08 ` JeffleXu
2021-08-17 14:11 ` Miklos Szeredi
2021-08-17 15:19 ` Vivek Goyal
2021-08-17 14:54 ` Vivek Goyal
2021-08-18 5:10 ` JeffleXu
2021-08-19 6:14 ` JeffleXu
2021-08-17 12:40 ` Vivek Goyal
2021-09-16 8:21 ` JeffleXu
2021-09-18 3:06 ` JeffleXu
2021-09-19 19:45 ` Vivek Goyal
2021-09-22 8:16 ` JeffleXu
2021-08-17 12:39 ` Vivek Goyal
2021-08-17 13:22 ` JeffleXu
2021-08-17 14:08 ` Miklos Szeredi
2021-08-18 3:39 ` JeffleXu
2021-08-18 5:08 ` Miklos Szeredi
2021-08-18 16:58 ` Vivek Goyal
2021-09-03 5:30 ` JeffleXu
2021-09-07 14:51 ` Miklos Szeredi
2021-08-17 14:57 ` Vivek Goyal
2021-08-18 5:20 ` JeffleXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRuO5ZzqDmuSC3pN@work-vm \
--to=dgilbert@redhat.com \
--cc=jefflexu@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).