From: Matthew Wilcox <willy@infradead.org>
To: gouhao@uniontech.com
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, axboe@kernel.dk,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/buffer: using __bio_add_page in submit_bh_wbc()
Date: Tue, 30 May 2023 04:39:38 +0100 [thread overview]
Message-ID: <ZHVv+rPl7iL3dMqi@casper.infradead.org> (raw)
In-Reply-To: <20230530033239.17534-1-gouhao@uniontech.com>
On Tue, May 30, 2023 at 11:32:39AM +0800, gouhao@uniontech.com wrote:
> From: Gou Hao <gouhao@uniontech.com>
>
> In submit_bh_wbc(), bio is newly allocated, so it
> does not need any merging logic.
>
> And using bio_add_page here will execute 'bio_flagged(
> bio, BIO_CLONED)' and 'bio_full' twice, which is unnecessary.
https://lore.kernel.org/linux-fsdevel/20230502101934.24901-5-johannes.thumshirn@wdc.com/
You could send some Reviewed-by: tags to that patch series.
next prev parent reply other threads:[~2023-05-30 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 3:32 [PATCH] fs/buffer: using __bio_add_page in submit_bh_wbc() gouhao
2023-05-30 3:39 ` Matthew Wilcox [this message]
2023-05-30 3:52 ` Gou Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHVv+rPl7iL3dMqi@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=gouhao@uniontech.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).