From: Luis Chamberlain <mcgrof@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
Zorro Lang <zlang@redhat.com>,
fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
patches@lists.linux.dev
Subject: Re: [PATCH] fstests: add helper to canonicalize devices used to enable persistent disks
Date: Wed, 26 Jul 2023 09:28:23 -0700 [thread overview]
Message-ID: <ZMFJp5OZN3vnT/yI@bombadil.infradead.org> (raw)
In-Reply-To: <20230726044132.GA30264@mit.edu>
On Wed, Jul 26, 2023 at 12:41:32AM -0400, Theodore Ts'o wrote:
> On Tue, Jul 25, 2023 at 08:54:39AM -0700, Darrick J. Wong wrote:
> > On Tue, Jul 25, 2023 at 04:13:07PM +0800, Zorro Lang wrote:
> > > On Wed, Jul 19, 2023 at 11:17:27PM -0700, Luis Chamberlain wrote:
> > > > The filesystem configuration file does not allow you to use symlinks to
> > > > devices given the existing sanity checks verify that the target end
> > > > device matches the source.
>
> I'm a little confused. Where are these "sanity checks" enforced?
> I've been using
>
> SCRATCH_DEV=/dev/mapper/xt-vdc
>
> where /dev/mapper/xt-vdc is a symlink to /dev/dm-4 (or some such)
> without any problems. So I don't quite understand why we need to
> canonicalize devices?
That might work, but try using /dev/disk/by-id/ stuff, that'll bust. So
to keep existing expecations by fstests, it's needed.
Luis
next prev parent reply other threads:[~2023-07-26 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 6:17 [PATCH] fstests: add helper to canonicalize devices used to enable persistent disks Luis Chamberlain
2023-07-24 10:58 ` Andrey Albershteyn
2023-07-25 8:13 ` Zorro Lang
2023-07-25 15:54 ` Darrick J. Wong
2023-07-25 17:50 ` Zorro Lang
2023-07-26 17:34 ` Luis Chamberlain
2023-07-26 4:41 ` Theodore Ts'o
2023-07-26 16:28 ` Luis Chamberlain [this message]
2023-07-27 1:13 ` Theodore Ts'o
2023-07-27 1:26 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMFJp5OZN3vnT/yI@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).