From: Matthew Wilcox <willy@infradead.org>
To: Pankaj Raghav <kernel@pankajraghav.com>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, gost.dev@samsung.com,
linux-kernel@vger.kernel.org,
Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH] filemap: call filemap_get_folios_tag() from filemap_get_folios()
Date: Fri, 6 Oct 2023 15:41:28 +0100 [thread overview]
Message-ID: <ZSAcmFaZC9d4VJNF@casper.infradead.org> (raw)
In-Reply-To: <20231006110120.136809-1-kernel@pankajraghav.com>
On Fri, Oct 06, 2023 at 01:01:20PM +0200, Pankaj Raghav wrote:
> From: Pankaj Raghav <p.raghav@samsung.com>
>
> filemap_get_folios() is filemap_get_folios_tag() with XA_PRESENT as the
> tag that is being matched. Return filemap_get_folios_tag() with
> XA_PRESENT as the tag instead of duplicating the code in
> filemap_get_folios().
Yes, I think this makes sense. I was consciously trying to make them
as similar to each other as possible. I hadn't realised I'd succeeded
to such an extent.
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
prev parent reply other threads:[~2023-10-06 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 11:01 [PATCH] filemap: call filemap_get_folios_tag() from filemap_get_folios() Pankaj Raghav
2023-10-06 14:41 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSAcmFaZC9d4VJNF@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=gost.dev@samsung.com \
--cc=kernel@pankajraghav.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).